[Bug default/27269] New: Assertion comparing ABIs on Fedora 33

[Bug default/27269] New: Assertion comparing ABIs on Fedora 33

[bugzilla at hadess dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=27269

            Bug ID: 27269
           Summary: Assertion comparing ABIs on Fedora 33
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: bugzilla at hadess dot net
                CC: dodji at redhat dot com, libabigail at sourceware dot org
  Target Milestone: ---

+++ This bug was initially created as a clone of Bug #27267 +++

libabigail-1.8-2.fc33.x86_64

totem-pl-parser's upstream CI pipeline uses abidiff to make sure that there
aren't unwanted ABI changes between versions.

This currently fails, as the rawhide toolchain seems to have moved to a new
version of DWARF which libabigail doesn't handle.

The error:
# abidiff --headers-dir1
/tmp/totem-pl-parser/9ccc3c78a5a41b86bdd2c9fb63ad4963e65e4f63/usr/include
--headers-dir2
/tmp/totem-pl-parser/b58c60f8fd94ecf4a2896a6a26528520bda37435/usr/include
--drop-private-types --fail-no-debug-info --no-added-syms
/tmp/totem-pl-parser/9ccc3c78a5a41b86bdd2c9fb63ad4963e65e4f63/usr/lib/libtotem-plparser.so
/tmp/totem-pl-parser/b58c60f8fd94ecf4a2896a6a26528520bda37435/usr/lib/libtotem-plparser.so
/usr/include/c++/10/bits/shared_ptr_base.h:1010: std::__shared_ptr_access<_Tp,
_Lp, <anonymous>, <anonymous> >::element_type& std::__shared_ptr_access<_Tp,
_Lp, <anonymous>, <anonymous> >::operator*() const [with _Tp =
abigail::ir::type_base; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic;
bool <anonymous> = false; bool <anonymous> = false;
std::__shared_ptr_access<_Tp, _Lp, <anonymous>, <anonymous> >::element_type =
abigail::ir::type_base]: Assertion '_M_get() != nullptr' failed.
Aborted (core dumped)

Note that it works if you don't pass --header-dirX:
# abidiff  --drop-private-types --fail-no-debug-info --no-added-syms
/tmp/totem-pl-parser/9ccc3c78a5a41b86bdd2c9fb63ad4963e65e4f63/usr/lib/libtotem-plparser.so
/tmp/totem-pl-parser/b58c60f8fd94ecf4a2896a6a26528520bda37435/usr/lib/libtotem-plparser.so
Functions changes summary: 0 Removed, 1 Changed (8 filtered out), 0 Added (3
filtered out) functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'function void totem_pl_parser_add_ignored_mimetype(TotemPlParser*, const
char*)' at totem-pl-parser.c:2409:1 has some indirect sub-type changes:
    parameter 1 of type 'TotemPlParser*' has sub-type changes:
      in pointed to type 'typedef TotemPlParser' at totem-pl-parser.h:70:1:
        underlying type 'struct {GObject parent; TotemPlParserPrivate* priv;}'
at totem-pl-parser.h:67:1 changed:
          type size hasn't changed
          1 data member change:
            type of 'TotemPlParserPrivate* priv' changed:
              in pointed to type 'typedef TotemPlParserPrivate' at
totem-pl-parser.h:60:1:
                underlying type 'struct TotemPlParserPrivate' at
totem-pl-parser.c:260:1 changed:
                  type size changed from 320 to 384 (in bits)
                  1 data member insertion:
                    'GHashTable* TotemPlParserPrivate::ignore_globs', at offset
128 (in bits) at totem-pl-parser.c:261:1
                  2 data member changes:
                    'GMutex TotemPlParserPrivate::ignore_mutex' offset changed
from 128 to 192 (in bits) (by +64 bits)
                    'GThread* TotemPlParserPrivate::main_thread' offset changed
from 192 to 256 (in bits) (by +64 bits)


The repository for the library in question, although I don't think it's
necessarily a problem with just this library:
https://gitlab.gnome.org/GNOME/totem-pl-parser/

The CI pipeline:
https://gitlab.gnome.org/GNOME/totem-pl-parser/-/blob/master/.gitlab-ci.yml
if you want to reproduce the problem locally in a container.

The script:
https://gitlab.gnome.org/GNOME/totem-pl-parser/-/blob/master/.ci/check-abi

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27269] Assertion comparing ABIs on Fedora 33

[bugzilla at hadess dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=27269

--- Comment #1 from Bastien Nocera <bugzilla at hadess dot net> ---
The include files and binaries were uploaded at:
https://hadess.fedorapeople.org/abidiff-crash-f33-bug-27269.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27269] Assertion comparing ABIs on Fedora 33

[bugzilla at hadess dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=27269

--- Comment #2 from Bastien Nocera <bugzilla at hadess dot net> ---
libabigail-1.8.1-1.fc33.x86_64 from:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-c96002c1d9
still crashes

I've updated the tarball to actually include the libraries, not just a stale
link. Sorry about that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27269] Assertion comparing ABIs on Fedora 33

[bugzilla at hadess dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=27269

--- Comment #3 from Bastien Nocera <bugzilla at hadess dot net> ---
I'm using libabigail-1.7-2.fc33.x86_64 in the meanwhile, which seems to work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.