public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/27514] New: recursively compare libraries in abicompat
@ 2021-03-04 18:02 woodard at redhat dot com
  2021-03-04 18:02 ` [Bug default/27514] " woodard at redhat dot com
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: woodard at redhat dot com @ 2021-03-04 18:02 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=27514

            Bug ID: 27514
           Summary: recursively compare libraries in abicompat
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This is similar and kind of related to 27208 but goes a bit deeper.

abicompat currently only compares one library at a time when evaluating library
compatibility. For example:

abicompat app libfoo-v1 libfoo-v2 

The app is also likely to have other dependencies which require ABI artifacts
out of libfoo that the app itself may not use. 

app requires libfoo.so and libbar.so
   app only uses foo_init()
   libbar uses additional functions out of libfoo.so

Currently abicompat would say that app is compatible with libfoo so long as
foo_init() didn't change. However, if libfoo-v2 had changes that impacted
libbar.so which is needed by the app then libfoo-v2 is not compatible with the
app.

Therefore the comparison currently done by abicompat where it simply looks at
the undefined symbols in the app is not sufficient to guarantee that libfoo-v1
and libfoo-v2 are in fact compatible with the application. It must also look at
the dependencies needed by app and include any symbols provided by them.

To be able to address this problem while not breaking current behavior a new
mode of operation is needed for abicompat one that loads the corpora not just
for the app but also for all its dependencies and then does the abi comparison.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/27514] recursively compare libraries in abicompat
  2021-03-04 18:02 [Bug default/27514] New: recursively compare libraries in abicompat woodard at redhat dot com
@ 2021-03-04 18:02 ` woodard at redhat dot com
  2021-03-04 18:10 ` woodard at redhat dot com
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: woodard at redhat dot com @ 2021-03-04 18:02 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=27514

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27019
           Priority|P2                          |P1


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/27514] recursively compare libraries in abicompat
  2021-03-04 18:02 [Bug default/27514] New: recursively compare libraries in abicompat woodard at redhat dot com
  2021-03-04 18:02 ` [Bug default/27514] " woodard at redhat dot com
@ 2021-03-04 18:10 ` woodard at redhat dot com
  2021-03-23 13:34 ` woodard at redhat dot com
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: woodard at redhat dot com @ 2021-03-04 18:10 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=27514

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
I would argue that this is a very important bug because it points out that all
analysis that has been done with abicompat is potentially invalid.

To address this problem I have been working on a branch which does this. It can
be found here: https://github.com/woodard/libabigail/tree/newabicompat

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/27514] recursively compare libraries in abicompat
  2021-03-04 18:02 [Bug default/27514] New: recursively compare libraries in abicompat woodard at redhat dot com
  2021-03-04 18:02 ` [Bug default/27514] " woodard at redhat dot com
  2021-03-04 18:10 ` woodard at redhat dot com
@ 2021-03-23 13:34 ` woodard at redhat dot com
  2021-04-13 20:02 ` woodard at redhat dot com
  2021-06-23  5:23 ` marksmithh644 at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: woodard at redhat dot com @ 2021-03-23 13:34 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=27514

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27635

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
To be able to do the full closure computation without the original ELF binaries
the abixml file is required to include the undefined symbols.


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27635
[Bug 27635] abicompat doesn't handle abixml
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/27514] recursively compare libraries in abicompat
  2021-03-04 18:02 [Bug default/27514] New: recursively compare libraries in abicompat woodard at redhat dot com
                   ` (2 preceding siblings ...)
  2021-03-23 13:34 ` woodard at redhat dot com
@ 2021-04-13 20:02 ` woodard at redhat dot com
  2021-06-23  5:23 ` marksmithh644 at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: woodard at redhat dot com @ 2021-04-13 20:02 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=27514

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|27635                       |


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27635
[Bug 27635] abicompat doesn't handle abixml
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug default/27514] recursively compare libraries in abicompat
  2021-03-04 18:02 [Bug default/27514] New: recursively compare libraries in abicompat woodard at redhat dot com
                   ` (3 preceding siblings ...)
  2021-04-13 20:02 ` woodard at redhat dot com
@ 2021-06-23  5:23 ` marksmithh644 at gmail dot com
  4 siblings, 0 replies; 6+ messages in thread
From: marksmithh644 at gmail dot com @ 2021-06-23  5:23 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=27514

mark smith <marksmithh644 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marksmithh644 at gmail dot com

--- Comment #3 from mark smith <marksmithh644 at gmail dot com> ---
The abixml file must include the undefined symbols in order to do the full
closure computation without the original ELF binaries. By the way, if you're
interested in One Year Masters Programs Online click the link
https://www.onlinemasterscolleges.com/one-year-masters-programs-online

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-23  5:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 18:02 [Bug default/27514] New: recursively compare libraries in abicompat woodard at redhat dot com
2021-03-04 18:02 ` [Bug default/27514] " woodard at redhat dot com
2021-03-04 18:10 ` woodard at redhat dot com
2021-03-23 13:34 ` woodard at redhat dot com
2021-04-13 20:02 ` woodard at redhat dot com
2021-06-23  5:23 ` marksmithh644 at gmail dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).