[Bug default/27517] New: /usr/lib64/libphonenumber.so.8.12 fails self check

[Bug default/27517] New: /usr/lib64/libphonenumber.so.8.12 fails self check

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27517

            Bug ID: 27517
           Summary: /usr/lib64/libphonenumber.so.8.12 fails self check
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

/usr/lib64/libphonenumber.so.8.12 from libphonenumber-8.12.11-4.fc34.x86_64
fails self-check whit the latest trunk of libabigail as of:
8ae8dcb8d5b87dafd0b9fdd716654e4bf3284c95

Something seems wrong with the handling of the virtual table and that appears
to break the comparison.

Starting program: /home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw
--abidiff /usr/lib64/libphonenumber.so.8.12
Download failed: File exists.  Continuing without debug info for
/lib64/ld-linux-x86-64.so.2.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Download failed: File exists.  Continuing without debug info for
/lib64/libstdc++.so.6.
Functions changes summary: 0 Removed, 1 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'function bool
i18n::phonenumbers::LoadCompiledInMetadata(i18n::phonenumbers::PhoneMetadataCollection*)'
at shortnumberinfo.cc:37:1 has some indirect sub-type changes:
    parameter 1 of type 'i18n::phonenumbers::PhoneMetadataCollection*' has
sub-type changes:
      in pointed to type 'class i18n::phonenumbers::PhoneMetadataCollection' at
phonemetadata.pb.h:1289:1:
        type size hasn't changed
        14 member function insertions:
          'method virtual size_t
i18n::phonenumbers::PhoneMetadataCollection::ByteSizeLong() const' at
phonemetadata.pb.cc:2368:1, virtual at voffset 9/12
          'method virtual void
i18n::phonenumbers::PhoneMetadataCollection::CheckTypeAndMergeFrom(const
google::protobuf::MessageLite&)' at phonemetadata.pb.cc:2391:1, virtual at
voffset 8/12
          'method virtual void
i18n::phonenumbers::PhoneMetadataCollection::Clear()' at
phonemetadata.pb.cc:2295:1, virtual at voffset 5/12
          'method virtual int
i18n::phonenumbers::PhoneMetadataCollection::GetCachedSize() const' at
phonemetadata.pb.h:1368:1, virtual at voffset 10/12
          'method virtual std::string
i18n::phonenumbers::PhoneMetadataCollection::GetTypeName() const' at
phonemetadata.pb.cc:2425:1, virtual at voffset 2/12
          'method virtual bool
i18n::phonenumbers::PhoneMetadataCollection::IsInitialized() const' at
phonemetadata.pb.cc:2414:1, virtual at voffset 6/12
          'method virtual i18n::phonenumbers::PhoneMetadataCollection*
i18n::phonenumbers::PhoneMetadataCollection::New() const' at
phonemetadata.pb.h:1349:1, virtual at voffset 3/12
          'method virtual i18n::phonenumbers::PhoneMetadataCollection*
i18n::phonenumbers::PhoneMetadataCollection::New(google::protobuf::Arena*)
const' at phonemetadata.pb.h:1353:1, virtual at voffset 4/12
          'method virtual const char*
i18n::phonenumbers::PhoneMetadataCollection::_InternalParse(const char*,
google::protobuf::internal::ParseContext*)' at phonemetadata.pb.cc:2305:1,
virtual at voffset 11/12
          'method virtual google::protobuf::uint8*
i18n::phonenumbers::PhoneMetadataCollection::_InternalSerialize(google::protobuf::uint8*,
google::protobuf::io::EpsCopyOutputStream*) const' at
phonemetadata.pb.cc:2346:1, virtual at voffset 12/12
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' at
phonemetadata.pb.cc:2270:1
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' at
phonemetadata.pb.cc:2270:1
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' at
phonemetadata.pb.cc:2270:1
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' at
phonemetadata.pb.cc:2270:1
        14 member function changes:
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' has
some sub-type changes:
            implicit parameter 0 of type
'i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' has
some sub-type changes:
            implicit parameter 0 of type
'i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' has
some sub-type changes:
            implicit parameter 0 of type
'i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual
i18n::phonenumbers::PhoneMetadataCollection::~PhoneMetadataCollection(int)' has
some sub-type changes:
            implicit parameter 0 of type
'i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual std::string
i18n::phonenumbers::PhoneMetadataCollection::GetTypeName() const' has some
sub-type changes:
            implicit parameter 0 of type 'const
i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              in pointed to type 'const
i18n::phonenumbers::PhoneMetadataCollection':
                unqualified underlying type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual i18n::phonenumbers::PhoneMetadataCollection*
i18n::phonenumbers::PhoneMetadataCollection::New() const' has some sub-type
changes:
            return type changed:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
            implicit parameter 0 of type 'const
i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              in pointed to type 'const
i18n::phonenumbers::PhoneMetadataCollection':
                unqualified underlying type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual i18n::phonenumbers::PhoneMetadataCollection*
i18n::phonenumbers::PhoneMetadataCollection::New(google::protobuf::Arena*)
const' has some sub-type changes:
            return type changed:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
            implicit parameter 0 of type 'const
i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              in pointed to type 'const
i18n::phonenumbers::PhoneMetadataCollection':
                unqualified underlying type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual void
i18n::phonenumbers::PhoneMetadataCollection::Clear()' has some sub-type
changes:
            implicit parameter 0 of type
'i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual bool
i18n::phonenumbers::PhoneMetadataCollection::IsInitialized() const' has some
sub-type changes:
            implicit parameter 0 of type 'const
i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              in pointed to type 'const
i18n::phonenumbers::PhoneMetadataCollection':
                unqualified underlying type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual void
i18n::phonenumbers::PhoneMetadataCollection::CheckTypeAndMergeFrom(const
google::protobuf::MessageLite&)' has some sub-type changes:
            implicit parameter 0 of type
'i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual size_t
i18n::phonenumbers::PhoneMetadataCollection::ByteSizeLong() const' has some
sub-type changes:
            implicit parameter 0 of type 'const
i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              in pointed to type 'const
i18n::phonenumbers::PhoneMetadataCollection':
                unqualified underlying type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual int
i18n::phonenumbers::PhoneMetadataCollection::GetCachedSize() const' has some
sub-type changes:
            implicit parameter 0 of type 'const
i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              in pointed to type 'const
i18n::phonenumbers::PhoneMetadataCollection':
                unqualified underlying type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual const char*
i18n::phonenumbers::PhoneMetadataCollection::_InternalParse(const char*,
google::protobuf::internal::ParseContext*)' has some sub-type changes:
            implicit parameter 0 of type
'i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              pointed to type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
          'method virtual google::protobuf::uint8*
i18n::phonenumbers::PhoneMetadataCollection::_InternalSerialize(google::protobuf::uint8*,
google::protobuf::io::EpsCopyOutputStream*) const' has some sub-type changes:
            implicit parameter 0 of type 'const
i18n::phonenumbers::PhoneMetadataCollection*' has sub-type changes:
              in pointed to type 'const
i18n::phonenumbers::PhoneMetadataCollection':
                unqualified underlying type 'class
i18n::phonenumbers::PhoneMetadataCollection' changed, as being reported
        1 data member change:
          type of
'google::protobuf::RepeatedPtrField<i18n::phonenumbers::PhoneMetadata>
metadata_' changed:
            type size hasn't changed
            1 base class change:
              'class google::protobuf::internal::RepeatedPtrFieldBase' at
repeated_field.h:578:1 changed:
                type size hasn't changed
                1 data member change:
                  type of
'google::protobuf::internal::RepeatedPtrFieldBase::Rep* rep_' changed:
                    in pointed to type 'struct
google::protobuf::internal::RepeatedPtrFieldBase::Rep' at
repeated_field.h:737:1:
                      type size hasn't changed

[Inferior 1 (process 21908) exited with code 01]
No stack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27517] /usr/lib64/libphonenumber.so.8.12 fails self check

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27517

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
Another one which seems to have a similar problem with virtual tables is
/usr/lib64/libprotobuf.so.25.0.0 from protobuf-3.14.0-2.fc34.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27517] /usr/lib64/libphonenumber.so.8.12 fails self check

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27517

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
another one where the virtual table changes is
/usr/lib64/ceph/librbd/libceph_librbd_parent_cache.so.1.0.0 from
librbd1-16.1.0-0.4.snapshot.fc34.x86_64 

Starting program: /home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw
--abidiff /usr/lib64/ceph/librbd/libceph_librbd_parent_cache.so.1.0.0
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Functions changes summary: 0 Removed, 1 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'method virtual void
ceph::immutable_obj_cache::ObjectCacheRegReplyData::decode_payload(ceph::buffer::v15_2_0::list::const_iterator,
__u8)' at Types.cc:139:1 has some indirect sub-type changes:
    Please note that the symbol of this function is
_ZN4ceph19immutable_obj_cache24ObjectCacheReadRadosData14decode_payloadENS_6buffer7v15_2_04list13iterator_implILb1EEEh
     and it aliases symbol:
_ZN4ceph19immutable_obj_cache23ObjectCacheRegReplyData14decode_payloadENS_6buffer7v15_2_04list13iterator_implILb1EEEh
    'method virtual void
ceph::immutable_obj_cache::ObjectCacheRegReplyData::decode_payload(ceph::buffer::v15_2_0::list::const_iterator,
__u8)
{_ZN4ceph19immutable_obj_cache24ObjectCacheReadRadosData14decode_payloadENS_6buffer7v15_2_04list13iterator_implILb1EEEh,
_ZN4ceph19immutable_obj_cache23ObjectCacheRegReplyData14decode_payloadENS_6buffer7v15_2_04list13iterator_implILb1EEEh}'
now becomes 'method virtual void
ceph::immutable_obj_cache::ObjectCacheReadRadosData::decode_payload(ceph::buffer::v15_2_0::list::const_iterator,
__u8)
{_ZN4ceph19immutable_obj_cache24ObjectCacheReadRadosData14decode_payloadENS_6buffer7v15_2_04list13iterator_implILb1EEEh,
_ZN4ceph19immutable_obj_cache23ObjectCacheRegReplyData14decode_payloadENS_6buffer7v15_2_04list13iterator_implILb1EEEh}'
    implicit parameter 0 of type
'ceph::immutable_obj_cache::ObjectCacheRegReplyData*' changed:
      in pointed to type 'class
ceph::immutable_obj_cache::ObjectCacheRegReplyData' at Types.h:120:1:
        type name changed from
'ceph::immutable_obj_cache::ObjectCacheRegReplyData' to
'ceph::immutable_obj_cache::ObjectCacheReadRadosData'
        type size hasn't changed
        7 member function deletions:
          'method virtual void
ceph::immutable_obj_cache::ObjectCacheRegReplyData::decode_payload(ceph::buffer::v15_2_0::list::const_iterator,
__u8)' at Types.cc:71:1, virtual at voffset 3/5
          'method virtual void
ceph::immutable_obj_cache::ObjectCacheRegReplyData::encode_payload()' at
Types.cc:69:1, virtual at voffset 2/5
          'method virtual uint16_t
ceph::immutable_obj_cache::ObjectCacheRegReplyData::get_request_type()' at
Types.h:81:1, virtual at voffset 4/5
          'method virtual bool
ceph::immutable_obj_cache::ObjectCacheRegReplyData::payload_empty()' at
Types.h:82:1, virtual at voffset 5/5
          'method virtual
ceph::immutable_obj_cache::ObjectCacheRegReplyData::~ObjectCacheRegReplyData(int)'
at Types.cc:67:1
          'method virtual
ceph::immutable_obj_cache::ObjectCacheRegReplyData::~ObjectCacheRegReplyData(int)'
at Types.cc:67:1
          'method virtual
ceph::immutable_obj_cache::ObjectCacheRegReplyData::~ObjectCacheRegReplyData(int)'
at Types.cc:67:1
        7 member function insertions:
          'method virtual void
ceph::immutable_obj_cache::ObjectCacheReadRadosData::decode_payload(ceph::buffer::v15_2_0::list::const_iterator,
__u8)' at Types.cc:139:1, virtual at voffset 3/5
          'method virtual void
ceph::immutable_obj_cache::ObjectCacheReadRadosData::encode_payload()' at
Types.cc:137:1, virtual at voffset 2/5
          'method virtual uint16_t
ceph::immutable_obj_cache::ObjectCacheReadRadosData::get_request_type()' at
Types.h:128:1, virtual at voffset 4/5
          'method virtual bool
ceph::immutable_obj_cache::ObjectCacheReadRadosData::payload_empty()' at
Types.h:129:1, virtual at voffset 5/5
          'method virtual
ceph::immutable_obj_cache::ObjectCacheReadRadosData::~ObjectCacheReadRadosData(int)'
at Types.cc:135:1
          'method virtual
ceph::immutable_obj_cache::ObjectCacheReadRadosData::~ObjectCacheReadRadosData(int)'
at Types.cc:135:1
          'method virtual
ceph::immutable_obj_cache::ObjectCacheReadRadosData::~ObjectCacheReadRadosData(int)'
at Types.cc:135:1

[Inferior 1 (process 22180) exited with code 01]

The thing that is interesting is the type name change:
       type name changed from
'ceph::immutable_obj_cache::ObjectCacheRegReplyData' to
'ceph::immutable_obj_cache::ObjectCacheReadRadosData'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27517] /usr/lib64/libphonenumber.so.8.12 fails self check

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27517

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
Another one that may be the same but may also be different is:
/usr/lib64/libQtGui.so.4.8.7 from qt-x11-4.8.7-59.fc34.x86_64

in this case it isn't the virtual table but it does seem to have the same
inexplicable type swapping:
 'const QSpinBox' changed to 'const QDoubleSpinBox'

So it is hard to say if it is the same or different. Is the key feature the
swapping of the types or is it the vtable changing? After seeing a few of these
I think that the cause is the type swap and the vtable change is caused by that
rather than the other way around.

Reading symbols from abidw...
Starting program: /home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw
--abidiff /usr/lib64/libQtGui.so.4.8.7
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Functions changes summary: 0 Removed, 1 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'method virtual void QSpinBox::fixup(QString&) const' at
qspinbox.cpp:928:1 has some indirect sub-type changes:
    Please note that the symbol of this function is
_ZNK14QDoubleSpinBox5fixupER7QString
     and it aliases symbol: _ZNK8QSpinBox5fixupER7QString
    'method virtual void QSpinBox::fixup(QString&) const
{_ZNK14QDoubleSpinBox5fixupER7QString, _ZNK8QSpinBox5fixupER7QString}' now
becomes 'method virtual void QDoubleSpinBox::fixup(QString&) const
{_ZNK14QDoubleSpinBox5fixupER7QString, _ZNK8QSpinBox5fixupER7QString}'
    implicit parameter 0 of type 'const QSpinBox*' changed:
      in pointed to type 'const QSpinBox':
        'const QSpinBox' changed to 'const QDoubleSpinBox'

[Inferior 1 (process 22082) exited with code 01]

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27517] /usr/lib64/libphonenumber.so.8.12 fails self check

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27517

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27019

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
Continues to reproduce in the trunk as of
b215a2115376225b04b4d6b25acc6c5a1b4021e9


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27517] /usr/lib64/libphonenumber.so.8.12 fails self check

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27517

--- Comment #5 from Ben Woodard <woodard at redhat dot com> ---
This continues to manifest with /usr/lib64/libphonenumber.so.8.12 from
libphonenumber-8.12.11-5.fc34.x86_64 with
b00ba10e1deae4eae58cb783c01c69f384f392c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27517] /usr/lib64/libphonenumber.so.8.12 fails self check

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27517

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Ben Woodard <woodard at redhat dot com> ---
This seems to have been resolved as of 190350a35f842574cf15b9a98f1ccbc3aa31a840

-- 
You are receiving this mail because:
You are on the CC list for the bug.