[Bug default/27518] New: abidw aborts during self check of /usr/lib64/libvte-2.91.so.0.6200.3

[Bug default/27518] New: abidw aborts during self check of /usr/lib64/libvte-2.91.so.0.6200.3

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27518

            Bug ID: 27518
           Summary: abidw aborts during self check of
                    /usr/lib64/libvte-2.91.so.0.6200.3
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This is a different abort than the one which shows up in line 1303 this one is
abg-reader.cc:4297

This one happens with: /usr/lib64/libvte-2.91.so.0.6200.3 from
vte291-0.62.3-2.fc34.x86_64 with trunk version as of
8ae8dcb8d5b87dafd0b9fdd716654e4bf3284c95

Starting program: /home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw
--abidiff /usr/lib64/libvte-2.91.so.0.6200.3
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
abidw: ../../../libabigail/src/abg-reader.cc:4297:
std::shared_ptr<abigail::ir::typedef_decl>
abigail::xml_reader::build_typedef_decl(abigail::xml_reader::read_context&,
xmlNodePtr, bool): Assertion `__abg_cond__' failed.

Program received signal SIGABRT, Aborted.
0x00007ffff74d9292 in raise () from /lib64/libc.so.6
#0  0x00007ffff74d9292 in raise () from /lib64/libc.so.6
#1  0x00007ffff74c28a4 in abort () from /lib64/libc.so.6
#2  0x00007ffff74c2789 in __assert_fail_base.cold () from /lib64/libc.so.6
#3  0x00007ffff74d1a16 in __assert_fail () from /lib64/libc.so.6
#4  0x00007ffff7ea0994 in abigail::xml_reader::build_typedef_decl (ctxt=...,
node=0x5abab90, add_to_current_scope=<optimized out>) at
../../../libabigail/src/abg-reader.cc:4297
#5  0x00007ffff7eacf5e in abigail::xml_reader::handle_typedef_decl
(add_to_current_scope=true, node=0x5abab90, ctxt=...) at
../../../libabigail/src/abg-reader.cc:5702
#6  abigail::xml_reader::handle_element_node (ctxt=..., node=0x5abab90,
add_to_current_scope=true) at ../../../libabigail/src/abg-reader.cc:2175
#7  0x00007ffff7e97a1e in abigail::xml_reader::read_translation_unit
(node=<optimized out>, tu=..., ctxt=...) at
../../../libabigail/src/abg-reader.cc:1403
#8  abigail::xml_reader::get_or_read_and_add_translation_unit (ctxt=...,
node=<optimized out>) at ../../../libabigail/src/abg-reader.cc:1455
#9  0x00007ffff7e981ed in abigail::xml_reader::read_translation_unit_from_input
(ctxt=...) at ../../../libabigail/src/abg-reader.cc:1513
#10 0x00007ffff7e992f0 in abigail::xml_reader::read_corpus_from_input
(ctxt=...) at ../../../libabigail/src/abg-reader.cc:1961
#11 0x00007ffff7e9b09f in abigail::xml_reader::read_corpus_from_native_xml_file
(path="/tmp/libabigail-tmp-file-0fpoqf", env=env@entry=0x44ad40) at
/usr/include/c++/11/bits/shared_ptr_base.h:1290
#12 0x0000000000405237 in load_corpus_and_write_abixml (opts=...,
context=std::shared_ptr<abigail::dwarf_reader::read_context> (empty) = {...},
env=std::shared_ptr<abigail::ir::environment> (use count 1, weak count 0) =
{...}, argv=0x7fffffffdd08) at /usr/include/c++/11/bits/shared_ptr_base.h:1290
#13 main (argc=<optimized out>, argv=0x7fffffffdd08) at
../../../libabigail/tools/abidw.cc:851

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27518] abidw aborts during self check of /usr/lib64/libvte-2.91.so.0.6200.3

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27518

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27019


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27518] abidw aborts during self check of /usr/lib64/libvte-2.91.so.0.6200.3

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27518

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcermak at redhat dot com

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
This continues to happen with trunk up through:
b215a2115376225b04b4d6b25acc6c5a1b4021e9

Reading symbols from abidw...
Starting program: /home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw
--abidiff /usr/lib64/libvte-2.91.so.0.6200.3
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
abidw: ../../../libabigail/src/abg-reader.cc:4278:
std::shared_ptr<abigail::ir::typedef_decl>
abigail::xml_reader::build_typedef_decl(abigail::xml_reader::read_context&,
xmlNodePtr, bool): Assertion `__abg_cond__' failed.

Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
49        return ret;
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
#1  0x00007ffff74c38a4 in __GI_abort () at abort.c:79
#2  0x00007ffff74c3789 in __assert_fail_base (fmt=<optimized out>,
assertion=<optimized out>, file=<optimized out>, line=<optimized out>,
function=<optimized out>) at assert.c:92
#3  0x00007ffff74d2a16 in __GI___assert_fail (assertion=0x7ffff7f320c1
"__abg_cond__", file=0x7ffff7f3d560 "../../../libabigail/src/abg-reader.cc",
line=4278, function=0x7ffff7f3dd30 "std::shared_ptr<abigail::ir::typedef_decl>
abigail::xml_reader::build_typedef_decl(abigail::xml_reader::read_context&,
xmlNodePtr, bool)") at assert.c:101
#4  0x00007ffff7ea20f4 in abigail::xml_reader::build_typedef_decl (ctxt=...,
node=0x5acdf20, add_to_current_scope=<optimized out>) at
../../../libabigail/src/abg-reader.cc:4278
#5  0x00007ffff7eae6de in abigail::xml_reader::handle_typedef_decl
(add_to_current_scope=true, node=0x5acdf20, ctxt=...) at
../../../libabigail/src/abg-reader.cc:5683
#6  abigail::xml_reader::handle_element_node (ctxt=..., node=0x5acdf20,
add_to_current_scope=true) at ../../../libabigail/src/abg-reader.cc:2156
#7  0x00007ffff7e9904e in abigail::xml_reader::read_translation_unit
(node=<optimized out>, tu=..., ctxt=...) at
../../../libabigail/src/abg-reader.cc:1393
#8  abigail::xml_reader::get_or_read_and_add_translation_unit (ctxt=...,
node=<optimized out>) at ../../../libabigail/src/abg-reader.cc:1445
#9  0x00007ffff7e9981d in abigail::xml_reader::read_translation_unit_from_input
(ctxt=...) at ../../../libabigail/src/abg-reader.cc:1503
#10 0x00007ffff7e9aa20 in abigail::xml_reader::read_corpus_from_input
(ctxt=...) at ../../../libabigail/src/abg-reader.cc:1942
#11 0x00007ffff7e9c83f in abigail::xml_reader::read_corpus_from_native_xml_file
(path="/tmp/libabigail-tmp-file-Xsiv95", env=env@entry=0x44ad70) at
/usr/include/c++/11/bits/shared_ptr_base.h:1290
#12 0x000000000040520a in load_corpus_and_write_abixml (opts=...,
context=std::shared_ptr<abigail::dwarf_reader::read_context> (empty) = {...},
env=std::shared_ptr<abigail::ir::environment> (use count 1, weak count 0) =
{...}, argv=0x7fffffffdc98) at /usr/include/c++/11/bits/shared_ptr_base.h:1290
#13 main (argc=<optimized out>, argv=0x7fffffffdc98) at
../../../libabigail/tools/abidw.cc:849

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27518] abidw aborts during self check of /usr/lib64/libvte-2.91.so.0.6200.3

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27518

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
This no longer aborts. So that problem is resolved with the current libabigail
trunk. great! However, with the current version of libvte there are a bunch of
unspecified return type changes. I mentioned this in:
https://sourceware.org/bugzilla/show_bug.cgi?id=27969 where the current problem
may be a manifestation of a different problem. Or it may be non-crashing
continuation of this problem. 

$ abidiff --harmless  /usr/lib64/libvte-2.91.so.0.6400.1 libvte.abixml
Functions changes summary: 0 Removed, 12 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

12 functions with some indirect sub-type change:

  [C] 'function GType vte_cursor_blink_mode_get_type()' at
vtetypebuiltins.cc:7:1 has some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_cursor_shape_get_type()' at vtetypebuiltins.cc:27:1
has some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_erase_binding_get_type()' at vtetypebuiltins.cc:68:1
has some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_format_get_type()' at vtetypebuiltins.cc:171:1 has
some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_pty_error_get_type()' at vtetypebuiltins.cc:90:1 has
some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_pty_flags_get_type()' at vtetypebuiltins.cc:109:1 has
some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_pty_get_type()' at vtepty.cc:338:1 has some indirect
sub-type changes:
    return type changed:

  [C] 'function GType vte_regex_error_get_type()' at vtetypebuiltins.cc:152:1
has some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_regex_get_type()' at vteregex.cc:46:1 has some
indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_terminal_get_type()' at vtegtk.cc:129:1 has some
indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_text_blink_mode_get_type()' at
vtetypebuiltins.cc:47:1 has some indirect sub-type changes:
    return type changed:

  [C] 'function GType vte_write_flags_get_type()' at vtetypebuiltins.cc:134:1
has some indirect sub-type changes:
    return type changed:

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27518] abidw aborts during self check of /usr/lib64/libvte-2.91.so.0.6200.3

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27518

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
fixed as of 190350a35f842574cf15b9a98f1ccbc3aa31a840

-- 
You are receiving this mail because:
You are on the CC list for the bug.