From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/27599] New: abidiff's notion of harmless union diff may need refinement
Date: Wed, 17 Mar 2021 22:46:10 +0000 [thread overview]
Message-ID: <bug-27599-9487@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=27599
Bug ID: 27599
Summary: abidiff's notion of harmless union diff may need
refinement
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: gprocida+abigail at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
The fix to PR24731 introduced the notion of harmless union diffs.
Occasionally we check what is being reported as filtered out by abidiff and
peek in more detail with abidiff --harmless. Alas, for kernel code, this
usually generates massive diffs and it's quite hard to spot the real causes.
This bug report is about a frequent red herring in such diffs.
The file tests/data/test-diff-dwarf/PR25058-liblttng-ctl-report-1.txt
illustrates the issue on a smaller scale.
There are two diff stanzas of interest.
type of 'union {char* string; uint64_t constant; double float_constant; char*
identifier; filter_node* child;} u' changed
and
underlying type 'union YYSTYPE' changed
Both have members of type filter_node* (which has changed... somewhere).
Emitting the "harmless union diff" text here is unhelpful as union definition
is unchanged. The current test for a harmless union change is effectively
(sizes are equal and) has_changes() which amounts to an equality comparison of
the two union types.
abidiff --leaf-changes-only doesn't report these changes at all.
[As an aside and to give an idea of what I mean by "massive". I compared two
ABIs I expected to be equal.
abidiff --leaf-changes-only: 0 changes, no diff
abidiff --leaf-changes-only --harmless: 0 changes, 0 no diff
abidiff: 1861 filtered out function and variable changes, no diff
abidiff --harmless: 23848 lines of output
A second trigger appears to be some definition/declaration issues in the XML
which don't get picked up in leaf mode here either.]
--
You are receiving this mail because:
You are on the CC list for the bug.
reply other threads:[~2021-03-17 22:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27599-9487@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).