[Bug default/28316] New: instability in anonymous enums

[Bug default/28316] New: instability in anonymous enums

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28316

            Bug ID: 28316
           Summary: instability in anonymous enums
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

With the latest trunk as of 190350a35f842574cf15b9a98f1ccbc3aa31a840 there
seems to be some ABI instability related to anonymous enums. There are three
libraries from three different packages impacted by this:
    /usr/lib64/dyninst/libcommon.so.10.2.1 from dyninst-10.2.1-6.fc34.x86_64
    /usr/lib64/libgjs.so.0.0.0 from gjs-1.68.3-1.fc34.x86_64
    /usr/lib64/libmozjs-78.so.0.0.0 from mozjs78-78.13.0-1.fc34.x86_64

This could be related to 27727 which also seems to be related to anonymous
enums but that appears to be a different problem.

------
/home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw --abidiff
/usr/lib64/dyninst/libcommon.so.10.2.1

Functions changes summary: 0 Removed, 1 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'function const char*
Dyninst::storageRefClass2Str(Dyninst::storageRefClass)' at
VariableLocation.C:51:1 has some indirect sub-type changes:
    parameter 1 of type 'typedef Dyninst::storageRefClass' changed:
      underlying type 'enum Dyninst::__anonymous_enum__' at
VariableLocation.h:63:1 changed:
        type size hasn't changed
        3 enumerator deletions:
          'Dyninst::__anonymous_enum__::storageRefUnset' value '0'
          'Dyninst::__anonymous_enum__::storageRef' value '1'
          'Dyninst::__anonymous_enum__::storageNoRef' value '2'
        3 enumerator insertions:
          'r_debug::__anonymous_enum__::RT_CONSISTENT' value '0'
          'r_debug::__anonymous_enum__::RT_ADD' value '1'
          'r_debug::__anonymous_enum__::RT_DELETE' value '2'

-----
/home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw --abidiff
/usr/lib64/libgjs.so.0.0.0
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Functions changes summary: 0 Removed, 2 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

2 functions with some indirect sub-type change:

  [C] 'function void
gjs_dbus_implementation_emit_property_changed(GjsDBusImplementation*, gchar*,
GVariant*)' at gjs-gdbus-wrapper.c:360:1 has some indirect sub-type changes:
    parameter 1 of type 'GjsDBusImplementation*' has sub-type changes:
      in pointed to type 'typedef GjsDBusImplementation' at
gjs-gdbus-wrapper.h:32:1:
        underlying type 'struct _GjsDBusImplementation' at
gjs-gdbus-wrapper.h:27:1 changed:
          type size hasn't changed
          1 data member change:
            type of 'GjsDBusImplementationPrivate* priv' changed:
              in pointed to type 'typedef GjsDBusImplementationPrivate' at
gjs-gdbus-wrapper.h:18:1:
                underlying type 'struct _GjsDBusImplementationPrivate' at
gjs-gdbus-wrapper.c:30:1 changed:
                  type size hasn't changed
                  1 data member change:
                    type of 'GDBusInterfaceInfo* ifaceinfo' changed:
                      in pointed to type 'typedef GDBusInterfaceInfo' at
giotypes.h:564:1:
                        underlying type 'struct _GDBusInterfaceInfo' at
gdbusintrospection.h:149:1 changed:
                          type size hasn't changed
                          1 data member change:
                            type of 'GDBusPropertyInfo** properties' changed:
                              in pointed to type 'GDBusPropertyInfo*':
                                in pointed to type 'typedef GDBusPropertyInfo'
at giotypes.h:563:1:
                                  underlying type 'struct _GDBusPropertyInfo'
at gdbusintrospection.h:126:1 changed:
                                    type size hasn't changed
                                    1 data member change:
                                      type of 'GDBusPropertyInfoFlags flags'
changed:
                                        underlying type 'enum
__anonymous_enum__' at gioenums.h:1343:1 changed:
                                          type size hasn't changed

  [C] 'function void
gjs_dbus_implementation_emit_signal(GjsDBusImplementation*, gchar*, GVariant*)'
at gjs-gdbus-wrapper.c:380:1 has some indirect sub-type changes:
    parameter 1 of type 'GjsDBusImplementation*' has sub-type changes:
      pointed to type 'typedef GjsDBusImplementation' changed at
gjs-gdbus-wrapper.h:32:1, as reported earlier

-----
 /home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw --abidiff
/usr/lib64/libmozjs-78.so.0.0.0

Functions changes summary: 0 Removed, 7 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

7 functions with some indirect sub-type change:

  [C] 'function bool JS_CopyPropertyFrom(JSContext*, JS::HandleId,
JS::HandleObject, JS::HandleObject, PropertyCopyBehavior)' at
JSObject.cpp:1092:1 has some indirect sub-type changes:
    parameter 5 of type 'typedef PropertyCopyBehavior' has sub-type changes:
      underlying type 'enum __anonymous_enum__' at jsfriendapi.h:361:1 changed:
        type size hasn't changed
        2 enumerator deletions:
          '__anonymous_enum__::MakeNonConfigurableIntoConfigurable' value '0'
          '__anonymous_enum__::CopyNonConfigurableAsIs' value '1'
        2 enumerator insertions:
          '__anonymous_enum__1::LZ4F_blockLinked' value '0'
          '__anonymous_enum__1::LZ4F_blockIndependent' value '1'

  [C] 'function size_t LZ4F_compressBegin(LZ4F_cctx*, void*, size_t, const
LZ4F_preferences_t*)' at lz4frame.c:711:1 has some indirect sub-type changes:
    parameter 4 of type 'const LZ4F_preferences_t*' has sub-type changes:
      in pointed to type 'const LZ4F_preferences_t':
        in unqualified underlying type 'typedef LZ4F_preferences_t' at
lz4frame.h:192:1:
          underlying type 'struct {LZ4F_frameInfo_t frameInfo; int
compressionLevel; unsigned int autoFlush; unsigned int favorDecSpeed; unsigned
int reserved[3];}' at lz4frame.h:186:1 changed:
            type size hasn't changed
            1 data member change:
              type of 'LZ4F_frameInfo_t frameInfo' changed:
                underlying type 'struct {LZ4F_blockSizeID_t blockSizeID;
LZ4F_blockMode_t blockMode; LZ4F_contentChecksum_t contentChecksumFlag;
LZ4F_frameType_t frameType; long long unsigned int contentSize; unsigned int
dictID; LZ4F_blockChecksum_t blockChecksumFlag;}' at lz4frame.h:169:1 changed:
                  type size hasn't changed
                  4 data member changes:
                    type of 'LZ4F_blockMode_t blockMode' changed:
                      underlying type 'enum __anonymous_enum__' changed at
lz4frame.h:132:1, as reported earlier
                    type of 'LZ4F_contentChecksum_t contentChecksumFlag'
changed:
                      underlying type 'enum __anonymous_enum__' changed at
lz4frame.h:139:1, as reported earlier
                    type of 'LZ4F_frameType_t frameType' changed:
                      underlying type 'enum __anonymous_enum__' changed at
lz4frame.h:151:1, as reported earlier
                    type of 'LZ4F_blockChecksum_t blockChecksumFlag' changed:
                      underlying type 'enum __anonymous_enum__' changed at
lz4frame.h:146:1, as reported earlier

  [C] 'function size_t LZ4F_compressBound(size_t, const LZ4F_preferences_t*)'
at lz4frame.c:725:1 has some indirect sub-type changes:
    parameter 2 of type 'const LZ4F_preferences_t*' has sub-type changes:
      in pointed to type 'const LZ4F_preferences_t':
        unqualified underlying type 'typedef LZ4F_preferences_t' changed at
lz4frame.h:192:1, as reported earlier

  [C] 'function size_t LZ4F_compressFrame(void*, size_t, void*, size_t, const
LZ4F_preferences_t*)' at lz4frame.c:428:1 has some indirect sub-type changes:
    parameter 5 of type 'const LZ4F_preferences_t*' has sub-type changes:
      in pointed to type 'const LZ4F_preferences_t':
        unqualified underlying type 'typedef LZ4F_preferences_t' changed at
lz4frame.h:192:1, as reported earlier

  [C] 'function size_t LZ4F_compressFrameBound(size_t, const
LZ4F_preferences_t*)' at lz4frame.c:350:1 has some indirect sub-type changes:
    parameter 2 of type 'const LZ4F_preferences_t*' has sub-type changes:
      in pointed to type 'const LZ4F_preferences_t':
        unqualified underlying type 'typedef LZ4F_preferences_t' changed at
lz4frame.h:192:1, as reported earlier

  [C] 'function LZ4F_errorCode_t LZ4F_getFrameInfo(LZ4F_dctx*,
LZ4F_frameInfo_t*, void*, size_t*)' at lz4frame.c:1239:1 has some indirect
sub-type changes:
    parameter 2 of type 'LZ4F_frameInfo_t*' has sub-type changes:
      pointed to type 'typedef LZ4F_frameInfo_t' changed at lz4frame.h:177:1,
as reported earlier

  [C] 'function void js::DumpHeap(JSContext*, FILE*,
js::DumpHeapNurseryBehaviour, mozilla::MallocSizeOf)' at jsfriendapi.cpp:1215:1
has some indirect sub-type changes:
    parameter 3 of type 'typedef js::DumpHeapNurseryBehaviour' changed:
      underlying type 'enum js::__anonymous_enum__' at jsfriendapi.h:435:1
changed:
        type size hasn't changed
        2 enumerator deletions:
          'js::__anonymous_enum__::CollectNurseryBeforeDump' value '0'
          'js::__anonymous_enum__::IgnoreNurseryObjects' value '1'
        2 enumerator insertions:
          'js::wasm::ABIResultIter::__anonymous_enum__::Next' value '0'
          'js::wasm::ABIResultIter::__anonymous_enum__::Prev' value '1'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/28316] instability in anonymous enums

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28316

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27019


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/28316] instability in anonymous enums

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28316

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
This continues to be a problem with the trunk as of
7488c8df3bf10750ce059a0ec1d44d8149149c86

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/28316] instability in anonymous enums

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28316

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28319

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
I think that it is likely that 28319 is a duplicate of this bug. Let's link
them but until we get a clear resolution keep both of them open.


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=28319
[Bug 28319] abidw - regression in treatment of anonymous enums in structs
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/28316] instability in anonymous enums

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28316

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/28316] Failure to represent typedef named anonymous enums

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28316

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|instability in anonymous    |Failure to represent
                   |enums                       |typedef named anonymous
                   |                            |enums

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/28316] Failure to represent typedef named anonymous enums

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28316

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from dodji at redhat dot com ---
This should now be fixed in master by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=321da6667884ddd13f30d21a9ed0c92d42f302fe.

The fix should be available in the 2.0 version.

Thanks for reporting this and sorry for the inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.