From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28364] libwiretap fails self check with unspecified indirect sup-type changes
Date: Thu, 30 Sep 2021 17:45:26 +0000 [thread overview]
Message-ID: <bug-28364-9487-inJ7BavKfG@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28364-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=28364
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #1 from dodji at redhat dot com ---
I looked into this and got puzzled for a long while.
I think I know have a theory about what's going on.
I think something is going on in canonicalization of function types and it has
to do with the type canonicalization propagation optimization. That one again.
To demonstrate what I mean, I put up a candidate patch that disables type
canonicalization for function types. Function types are thus compared
structurally. Thins are still fast because the sub-objects of function types
are canonicalized. And this fixes the issue. So I need to understand why
exactly type canonicalization on function types is failing on this binary.
I've put the candidate patch here
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/PR28364.
When I understand why exactly function types canonicalization is failing, we
should stop disabling function type canonicalization.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2021-09-30 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 20:11 [Bug default/28364] New: " woodard at redhat dot com
2021-09-21 20:11 ` [Bug default/28364] " woodard at redhat dot com
2021-09-30 17:45 ` dodji at redhat dot com [this message]
2021-10-18 9:01 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-28364-9487-inJ7BavKfG@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).