* [Bug default/28364] New: libwiretap fails self check with unspecified indirect sup-type changes
@ 2021-09-21 20:11 woodard at redhat dot com
2021-09-21 20:11 ` [Bug default/28364] " woodard at redhat dot com
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: woodard at redhat dot com @ 2021-09-21 20:11 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=28364
Bug ID: 28364
Summary: libwiretap fails self check with unspecified indirect
sup-type changes
Product: libabigail
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: woodard at redhat dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
With trunk as of 1115e3f08e8f30e7e412294a563a78a15d0373c1
/usr/lib64/libwiretap.so.11.0.8 from wireshark-cli-3.4.8-1.fc34.x86_64 fails
consistency test.
/home/ben/Shared/Work/test/libabigail-x86_64/bin/abidw --abidiff
/usr/lib64/libwiretap.so.11.0.8
Functions changes summary: 0 Removed, 3 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
3 functions with some indirect sub-type change:
[C] 'function void wtap_cleareof(wtap*)' at wtap.c:1421:1 has some indirect
sub-type changes:
[C] 'function void wtap_fdclose(wtap*)' at wtap.c:1386:1 has some indirect
sub-type changes:
[C] 'function void wtap_sequential_close(wtap*)' at wtap.c:1362:1 has some
indirect sub-type changes:
[Inferior 1 (process 1698173) exited with code 01]
Not a lot to go on with regards to what the indirect sub-type changes are.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/28364] libwiretap fails self check with unspecified indirect sup-type changes
2021-09-21 20:11 [Bug default/28364] New: libwiretap fails self check with unspecified indirect sup-type changes woodard at redhat dot com
@ 2021-09-21 20:11 ` woodard at redhat dot com
2021-09-30 17:45 ` dodji at redhat dot com
2021-10-18 9:01 ` dodji at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: woodard at redhat dot com @ 2021-09-21 20:11 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=28364
Ben Woodard <woodard at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |27019
Referenced Bugs:
https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/28364] libwiretap fails self check with unspecified indirect sup-type changes
2021-09-21 20:11 [Bug default/28364] New: libwiretap fails self check with unspecified indirect sup-type changes woodard at redhat dot com
2021-09-21 20:11 ` [Bug default/28364] " woodard at redhat dot com
@ 2021-09-30 17:45 ` dodji at redhat dot com
2021-10-18 9:01 ` dodji at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dodji at redhat dot com @ 2021-09-30 17:45 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=28364
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #1 from dodji at redhat dot com ---
I looked into this and got puzzled for a long while.
I think I know have a theory about what's going on.
I think something is going on in canonicalization of function types and it has
to do with the type canonicalization propagation optimization. That one again.
To demonstrate what I mean, I put up a candidate patch that disables type
canonicalization for function types. Function types are thus compared
structurally. Thins are still fast because the sub-objects of function types
are canonicalized. And this fixes the issue. So I need to understand why
exactly type canonicalization on function types is failing on this binary.
I've put the candidate patch here
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/PR28364.
When I understand why exactly function types canonicalization is failing, we
should stop disabling function type canonicalization.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug default/28364] libwiretap fails self check with unspecified indirect sup-type changes
2021-09-21 20:11 [Bug default/28364] New: libwiretap fails self check with unspecified indirect sup-type changes woodard at redhat dot com
2021-09-21 20:11 ` [Bug default/28364] " woodard at redhat dot com
2021-09-30 17:45 ` dodji at redhat dot com
@ 2021-10-18 9:01 ` dodji at redhat dot com
2 siblings, 0 replies; 4+ messages in thread
From: dodji at redhat dot com @ 2021-10-18 9:01 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=28364
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #2 from dodji at redhat dot com ---
This bug should now be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=991283269ea8eb9bf9b1d1f460164c222f60e888
and should be available in libabigail 2.1.
Thanks for reporting this issue!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-18 9:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21 20:11 [Bug default/28364] New: libwiretap fails self check with unspecified indirect sup-type changes woodard at redhat dot com
2021-09-21 20:11 ` [Bug default/28364] " woodard at redhat dot com
2021-09-30 17:45 ` dodji at redhat dot com
2021-10-18 9:01 ` dodji at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).