public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/28641] unspecified indirect subtype changes.
Date: Wed, 08 Dec 2021 18:54:32 +0000	[thread overview]
Message-ID: <bug-28641-9487-Tng9gTche3@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28641-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28641

--- Comment #6 from Ben Woodard <woodard at redhat dot com> ---
The functions that I pointed out in the previous comment are all _ZNK
functions. You can overload on the const'ness of a function and so it has to be
encoded in the mangling of the linkage name.

struct X { void foo(); void foo() const; };

We should try to get this fixed in clang so that it correctly encodes the
const'ness of the function in the DWARF. However, we are going to need to deal
with all the versions of clang which don't get this right. So I propose a
fixup: if the function has the K attribute in its name mangling even if the
function's DWARF is not marked const then the function should be labeled as
const.

List of needed actions:
1) file a bug with clang
2) when the difference between two functions is const'ness print that out don't
just leave people with "...has some indirect sub-type changes:" then print
nothing.
3) if the function mangle name has the K in it, then mark it const in the IR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-12-08 18:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01 23:44 [Bug default/28641] New: " woodard at redhat dot com
2021-12-01 23:46 ` [Bug default/28641] " woodard at redhat dot com
2021-12-01 23:51 ` woodard at redhat dot com
2021-12-02  0:01 ` woodard at redhat dot com
2021-12-06 18:59 ` woodard at redhat dot com
2021-12-07  0:54 ` woodard at redhat dot com
2021-12-08 18:52 ` jwakely.gcc at gmail dot com
2021-12-08 18:54 ` woodard at redhat dot com [this message]
2021-12-08 19:36 ` woodard at redhat dot com
2021-12-08 20:27 ` woodard at redhat dot com
2021-12-08 23:38 ` gprocida at google dot com
2021-12-08 23:56 ` [Bug default/28641] const'ness of member functions is not detected in clang++ binaries woodard at redhat dot com
2021-12-09 11:18 ` gprocida at google dot com
2021-12-09 11:25 ` jwakely.gcc at gmail dot com
2021-12-09 11:32 ` jwakely.gcc at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28641-9487-Tng9gTche3@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).