public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/28675] New: whitespace in DWARF template naming confuses libabigail.
@ 2021-12-08 23:44 woodard at redhat dot com
  2021-12-08 23:44 ` [Bug default/28675] " woodard at redhat dot com
  2021-12-09  0:10 ` woodard at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: woodard at redhat dot com @ 2021-12-08 23:44 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=28675

            Bug ID: 28675
           Summary: whitespace in DWARF template naming confuses
                    libabigail.
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Comparing gcc built libabigail.so.0 to llvm built libabigail.so.0 one of the
commonly reported differences is like this:

  [C] 'method const std::vector<abigail::comparison::diff*,
std::allocator<abigail::comparison::diff*> >&
abigail::comparison::corpus_diff::children_nodes() const' at
abg-comparison.h:2325:1 has some indirect sub-type changes:
    return type changed:
      in referenced type 'const std::vector<abigail::comparison::diff*,
std::allocator<abigail::comparison::diff*> >':
        'const std::vector<abigail::comparison::diff*,
std::allocator<abigail::comparison::diff*> >' changed to 'const
std::vector<abigail::comparison::diff *,
std::allocator<abigail::comparison::diff *> >'

The difference is nothing other than white space:
const std::vector<abigail::comparison::diff*,
std::allocator<abigail::comparison::diff*> >
const std::vector<abigail::comparison::diff *,
std::allocator<abigail::comparison::diff *> >

clang puts a space between typename and the * while GCC does not.

This should be a special case that is handled by libabigail. It is not an
actual ABI difference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/28675] whitespace in DWARF template naming confuses libabigail.
  2021-12-08 23:44 [Bug default/28675] New: whitespace in DWARF template naming confuses libabigail woodard at redhat dot com
@ 2021-12-08 23:44 ` woodard at redhat dot com
  2021-12-09  0:10 ` woodard at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: woodard at redhat dot com @ 2021-12-08 23:44 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=28675

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27019


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/28675] whitespace in DWARF template naming confuses libabigail.
  2021-12-08 23:44 [Bug default/28675] New: whitespace in DWARF template naming confuses libabigail woodard at redhat dot com
  2021-12-08 23:44 ` [Bug default/28675] " woodard at redhat dot com
@ 2021-12-09  0:10 ` woodard at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: woodard at redhat dot com @ 2021-12-09  0:10 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=28675

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
This may be a duplicate of 28664 depending on how you frame it. In 28664 it has
to do with the template value parameter type. In this case it is the
representation of certain template type parameter.

One way of considering the bugs is that both have to do with string comparison
of the template typename vs. drilling down into the types being instantiated by
the template. In that case they may be the same bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-09  0:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 23:44 [Bug default/28675] New: whitespace in DWARF template naming confuses libabigail woodard at redhat dot com
2021-12-08 23:44 ` [Bug default/28675] " woodard at redhat dot com
2021-12-09  0:10 ` woodard at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).