From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29013] abicompat doesn't consider weak symbol replacement
Date: Thu, 31 Mar 2022 21:25:13 +0000 [thread overview]
Message-ID: <bug-29013-9487-SnkfMEUdOB@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29013-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=29013
--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
An example of where this could come up is when an application overrides a weak
symbol like malloc(). Malloc is such a trivial example people are unlikely to
screw that up but the point remains the ABI of the overridden call must match
the one who overrides.
The additional logic to check weak symbols would be similar to the logic found
in tools/abicompat.cc around line 720
722 for (elf_symbols::const_iterator i =
723 app_corpus->get_sorted_undefined_fun_symbols().begin();
724 i != app_corpus->get_sorted_undefined_fun_symbols().end();
725 ++i)
There would need to be a similar iterator for weak symbols.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2022-03-31 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 10:13 [Bug default/29013] New: " woodard at redhat dot com
2022-03-31 10:17 ` [Bug default/29013] " woodard at redhat dot com
2022-03-31 21:25 ` woodard at redhat dot com [this message]
2022-03-31 21:25 ` woodard at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29013-9487-SnkfMEUdOB@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).