public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29044] New: abidiff reporter inconsistency
Date: Mon, 11 Apr 2022 10:08:52 +0000	[thread overview]
Message-ID: <bug-29044-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=29044

            Bug ID: 29044
           Summary: abidiff reporter inconsistency
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 14057
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14057&action=edit
XML inputs and abidiff outputs

Hi Dodji.

While digging into another issue, I noticed an inconsistency between whether
abidiff and abidiff --leaf-changes-only considers there to be a ABI break.

The attachment contains two Android kernel XML files. An independent check
shows that the only differences between them are whether certain types are only
declared or fully defined.

1. abidiff reports that ir_raw_handler_register's type has changed.

2. abidiff --leaf-changes-only does not.

3. abidiff --harmless results in reports of lots of cases where only-declared
vs fully-defined is considered to be a harmless change.

4. abidiff --leaf-changes-only --harmless results in a single report that
struct drm_crtc_helper_funcs has been changed, but the report doesn't reach a
root cause.

In general, the inconsistency is a bit surprising, however, I think the best
places to look at in terms of bug hunting are 1 and 4 as, ignoring
only-declared vs fully-defined issues, nothing has changed between the two
ABIs.

Regards,
Giuliano.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2022-04-11 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 10:08 gprocida at google dot com [this message]
2022-05-30 15:22 ` [Bug default/29044] " dodji at redhat dot com
2022-05-30 16:15 ` gprocida at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29044-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).