* [Bug default/29047] New: abidiff statistics omit symbol with no debug info changes
@ 2022-04-11 15:43 gprocida at google dot com
2022-06-01 16:20 ` Dodji Seketeli
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: gprocida at google dot com @ 2022-04-11 15:43 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29047
Bug ID: 29047
Summary: abidiff statistics omit symbol with no debug info
changes
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: gprocida at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
From a recent report:
Leaf changes summary: 510 artifacts changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 499 Added
functions
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 11 Added
variables
Function symbols changes summary: 0 Removed, 0 Added function symbol not
referenced by debug info
Variable symbols changes summary: 0 Removed, 3 Added variable symbols not
referenced by debug info
510 = 499 + 11
but should be
513 = 499 + 11 + 3
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Bug default/29047] New: abidiff statistics omit symbol with no debug info changes
2022-04-11 15:43 [Bug default/29047] New: abidiff statistics omit symbol with no debug info changes gprocida at google dot com
@ 2022-06-01 16:20 ` Dodji Seketeli
2022-06-01 16:20 ` [Bug default/29047] " dodji at seketeli dot org
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Dodji Seketeli @ 2022-06-01 16:20 UTC (permalink / raw)
To: gprocida at google dot com via Libabigail; +Cc: gprocida at google dot com
gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:
> Leaf changes summary: 510 artifacts changed
> Changed leaf types summary: 0 leaf type changed
> Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 499 Added
> functions
> Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 11 Added
> variables
> Function symbols changes summary: 0 Removed, 0 Added function symbol not
> referenced by debug info
> Variable symbols changes summary: 0 Removed, 3 Added variable symbols not
> referenced by debug info
>
> 510 = 499 + 11
> but should be
> 513 = 499 + 11 + 3
Thank you for reporting this issue.
I posted a patch for this to
https://sourceware.org/pipermail/libabigail/2022q2/004385.html.
Do you see an improvement with that patch at all?
Thanks!
--
Dodji
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug default/29047] abidiff statistics omit symbol with no debug info changes
2022-04-11 15:43 [Bug default/29047] New: abidiff statistics omit symbol with no debug info changes gprocida at google dot com
2022-06-01 16:20 ` Dodji Seketeli
@ 2022-06-01 16:20 ` dodji at seketeli dot org
2022-06-02 8:48 ` gprocida at google dot com
2022-06-02 15:00 ` dodji at seketeli dot org
3 siblings, 0 replies; 6+ messages in thread
From: dodji at seketeli dot org @ 2022-06-01 16:20 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29047
--- Comment #1 from dodji at seketeli dot org ---
gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:
> Leaf changes summary: 510 artifacts changed
> Changed leaf types summary: 0 leaf type changed
> Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 499 Added
> functions
> Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 11 Added
> variables
> Function symbols changes summary: 0 Removed, 0 Added function symbol not
> referenced by debug info
> Variable symbols changes summary: 0 Removed, 3 Added variable symbols not
> referenced by debug info
>
> 510 = 499 + 11
> but should be
> 513 = 499 + 11 + 3
Thank you for reporting this issue.
I posted a patch for this to
https://sourceware.org/pipermail/libabigail/2022q2/004385.html.
Do you see an improvement with that patch at all?
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/29047] abidiff statistics omit symbol with no debug info changes
2022-04-11 15:43 [Bug default/29047] New: abidiff statistics omit symbol with no debug info changes gprocida at google dot com
2022-06-01 16:20 ` Dodji Seketeli
2022-06-01 16:20 ` [Bug default/29047] " dodji at seketeli dot org
@ 2022-06-02 8:48 ` gprocida at google dot com
2022-06-02 15:00 ` Dodji Seketeli
2022-06-02 15:00 ` dodji at seketeli dot org
3 siblings, 1 reply; 6+ messages in thread
From: gprocida at google dot com @ 2022-06-02 8:48 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29047
--- Comment #2 from gprocida at google dot com ---
The patch is good. Thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bug default/29047] abidiff statistics omit symbol with no debug info changes
2022-06-02 8:48 ` gprocida at google dot com
@ 2022-06-02 15:00 ` Dodji Seketeli
0 siblings, 0 replies; 6+ messages in thread
From: Dodji Seketeli @ 2022-06-02 15:00 UTC (permalink / raw)
To: gprocida at google dot com via Libabigail; +Cc: gprocida at google dot com
Hello,
gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:
> https://sourceware.org/bugzilla/show_bug.cgi?id=29047
>
> --- Comment #2 from gprocida at google dot com ---
> The patch is good. Thank you.
[...]
Dodji Seketeli <dodji@seketeli.org> a écrit:
>
> * src/abg-comparison.cc (corpus_diff::priv::emit_diff_stats): In
> the "leaf change summary" section, add the number of removed/added
> symbols not described by debug info.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/29047] abidiff statistics omit symbol with no debug info changes
2022-04-11 15:43 [Bug default/29047] New: abidiff statistics omit symbol with no debug info changes gprocida at google dot com
` (2 preceding siblings ...)
2022-06-02 8:48 ` gprocida at google dot com
@ 2022-06-02 15:00 ` dodji at seketeli dot org
3 siblings, 0 replies; 6+ messages in thread
From: dodji at seketeli dot org @ 2022-06-02 15:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29047
--- Comment #3 from dodji at seketeli dot org ---
Hello,
gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:
> https://sourceware.org/bugzilla/show_bug.cgi?id=29047
>
> --- Comment #2 from gprocida at google dot com ---
> The patch is good. Thank you.
[...]
Dodji Seketeli <dodji@seketeli.org> a écrit:
>
> * src/abg-comparison.cc (corpus_diff::priv::emit_diff_stats): In
> the "leaf change summary" section, add the number of removed/added
> symbols not described by debug info.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master, thanks!
[...]
Cheers,
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-02 15:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 15:43 [Bug default/29047] New: abidiff statistics omit symbol with no debug info changes gprocida at google dot com
2022-06-01 16:20 ` Dodji Seketeli
2022-06-01 16:20 ` [Bug default/29047] " dodji at seketeli dot org
2022-06-02 8:48 ` gprocida at google dot com
2022-06-02 15:00 ` Dodji Seketeli
2022-06-02 15:00 ` dodji at seketeli dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).