From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29144] abidiff does not report base class reordering
Date: Tue, 07 Jun 2022 20:06:41 +0000 [thread overview]
Message-ID: <bug-29144-9487-NiU6LIfPOJ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29144-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=29144
--- Comment #2 from gprocida at google dot com ---
Hi Dodji.
I think this works, at least to some degree. However, we were wondering if it
would make sense to mention *offsets* rather than just the *order* of base
classes.
There is also a second thing, one which I haven't had time to look into at all,
beyond vaguely remembering the distinction and compiling some code. Something
like the following. Or perhaps with s/class/struct/.
class base { int x; };
class a : base { int y; };
class b : base { int z; };
class derived : a, b { };
vs
class derived : virtual a, virtual b { };
I wonder if it's possible to get in a situation where layout changes are
missed.
Regards,
Giuliano.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2022-06-07 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 18:31 [Bug default/29144] New: " gprocida at google dot com
2022-06-03 10:36 ` [Bug default/29144] " dodji at redhat dot com
2022-06-07 13:04 ` [Bug default/29144] New: " Dodji Seketeli
2022-06-07 13:04 ` [Bug default/29144] " dodji at seketeli dot org
2022-06-07 20:06 ` gprocida at google dot com [this message]
2022-06-08 15:39 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-29144-9487-NiU6LIfPOJ@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).