[Bug default/29144] abidiff does not report base class reordering

["dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29144

--- Comment #3 from dodji at redhat dot com ---
(In reply to gprocida from comment #2)
> Hi Dodji.
> 
> I think this works, at least to some degree. However, we were wondering if
> it would make sense to mention *offsets* rather than just the *order* of
> base classes.
> 
> There is also a second thing, one which I haven't had time to look into at
> all, beyond vaguely remembering the distinction and compiling some code.
> Something like the following. Or perhaps with s/class/struct/.
> 
> class base { int x; };
> class a : base { int y;  };
> class b : base { int z; };
> 
> class derived : a, b { };
> 
> vs
> 
> class derived : virtual a, virtual b { };
> 
> I wonder if it's possible to get in a situation where layout changes are
> missed.

These are all valid points that I think we should revisit later when we are
more sure about what we want here.  For now, I have applied that patch to
master to at least detect something, rather than nothing.  I'll be glad to
explore this further when we are more sure about what we want.

I'll look at the later case you noted to see if we report anything at all. 
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.