public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29175] handling of symbols outside the first corpus in a corpus group
Date: Thu, 16 Jun 2022 16:28:56 +0000	[thread overview]
Message-ID: <bug-29175-9487-dsMlKELoMP@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29175-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29175

gprocida at google dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|abidiff ignores symbols     |handling of symbols outside
                   |outside the first corpus of |the first corpus in a
                   |a corpus group              |corpus group

--- Comment #1 from gprocida at google dot com ---
There are a few things to consider in abidw and abidiff handling of corpus
groups.

Are symbols in later corpus groups picked up by abidiff? No (this is the
original bug report).

Can symbols be duplicated between different corpora? Yes. Someone is building
lots of modules in one tree (but devices only ship / use a subset of modules
appropriate to the specific hardware). So only certain subsets of the corpora
are meaningful.

Does abidw do the right thing in terms of scoping elf-symbol-id to within each
corpus rather than across the whole DWARF reader / corpus group? Possibly not.

What if symbol x is "int x" in one corpus but "int x(double)" in another?

What will happen if parts of one type (say different member functions) are
spread across multiple corpora? Please don't do this.

I think it would be most useful if we could invent some test corpus groups,
without actually building kernels and kernel modules. I'll talk to Matthias
about this.

It would then be much easier to test and validate abidw behaviour.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2022-06-16 16:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 14:18 [Bug default/29175] New: abidiff ignore symbols outside the first corpus of " gprocida at google dot com
2022-05-24 20:29 ` [Bug default/29175] abidiff ignores " gprocida at google dot com
2022-06-16 16:28 ` gprocida at google dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29175-9487-dsMlKELoMP@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).