* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
@ 2022-07-08 2:39 ` woodard at redhat dot com
2022-07-08 2:47 ` woodard at redhat dot com
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2022-07-08 2:39 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
Ben Woodard <woodard at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|fedabipkgdiff |fedabipkgdiff
|--self-compare asserts on |--self-compare asserts on
|Gtk3Ada and Gtk3Ad2 |Gtk3Ada and Gtk3Ada
--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
this also affects ghdl and GtkAda
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
2022-07-08 2:39 ` [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada woodard at redhat dot com
@ 2022-07-08 2:47 ` woodard at redhat dot com
2022-07-26 15:42 ` woodard at redhat dot com
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2022-07-08 2:47 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
Ben Woodard <woodard at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |minor
--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Honestly a low priority package. I think it is enough that it doesn't assert.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
2022-07-08 2:39 ` [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada woodard at redhat dot com
2022-07-08 2:47 ` woodard at redhat dot com
@ 2022-07-26 15:42 ` woodard at redhat dot com
2022-10-14 18:49 ` woodard at redhat dot com
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2022-07-26 15:42 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
Ben Woodard <woodard at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29412
Referenced Bugs:
https://sourceware.org/bugzilla/show_bug.cgi?id=29412
[Bug 29412] Assertion metabug
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (2 preceding siblings ...)
2022-07-26 15:42 ` woodard at redhat dot com
@ 2022-10-14 18:49 ` woodard at redhat dot com
2022-12-16 20:21 ` woodard at redhat dot com
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2022-10-14 18:49 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
The package name has changed it is now GtkAda3
So has the line number for the assert but the problem still remains.
abipkgdiff: ../../../libabigail/src/abg-ir.cc:17342: uint64_t
abigail::ir::array_type_def::subrange_type::get_length() const: Assertion
`__abg_cond__' failed.
The packages that assert in this location are not all obviously related to Ada
but some of them are:
aws
ghdl
gnatcoll-core
gprbuild
GtkAda3
GtkAda
matreshka-amf
templates_parser
xmlada
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (3 preceding siblings ...)
2022-10-14 18:49 ` woodard at redhat dot com
@ 2022-12-16 20:21 ` woodard at redhat dot com
2023-03-23 23:01 ` woodard at redhat dot com
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2022-12-16 20:21 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
This continues to happen with 2.2 on the current trunk as of 1f51b9e8
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (4 preceding siblings ...)
2022-12-16 20:21 ` woodard at redhat dot com
@ 2023-03-23 23:01 ` woodard at redhat dot com
2023-03-27 21:11 ` woodard at redhat dot com
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2023-03-23 23:01 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
--- Comment #5 from Ben Woodard <woodard at redhat dot com> ---
continues to reproduce with the current trunk as of:
commit a8a4ca8862959e9fede1b4878469681b8fadeb74 (HEAD -> master, origin/master,
origin/HEAD)
Author: Dodji Seketeli <dodji@redhat.com>
Date: Wed Mar 22 15:42:43 2023 +0100
abipkgdiff: Fix a typo
* tools/abipkgdiff.cc (compare_to_self): Fix a typo.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (5 preceding siblings ...)
2023-03-23 23:01 ` woodard at redhat dot com
@ 2023-03-27 21:11 ` woodard at redhat dot com
2023-04-02 3:00 ` woodard at redhat dot com
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2023-03-27 21:11 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
Ben Woodard <woodard at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29340
Referenced Bugs:
https://sourceware.org/bugzilla/show_bug.cgi?id=29340
[Bug 29340] fedabipkgdiff --self-compare asserts on matreshka
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (6 preceding siblings ...)
2023-03-27 21:11 ` woodard at redhat dot com
@ 2023-04-02 3:00 ` woodard at redhat dot com
2023-04-06 11:20 ` dodji at redhat dot com
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: woodard at redhat dot com @ 2023-04-02 3:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
--- Comment #6 from Ben Woodard <woodard at redhat dot com> ---
It looks like a bit more is needed to get ada working. We are now hitting a new
assert that I haven't seen before:
../../../libabigail/src/abg-ir.cc:17399: uint64_t
abigail::ir::array_type_def::subrange_type::get_length() const: Assertion
`__abg_cond__' failed.
It kind of looks like it is related to the new independent range feature and
affects the following packages:
aws
ghdl
gnatcoll-core
gprbuild
GtkAda3
GtkAda
matreshka-amf
templates_parser
xmlada
This is with:
commit ddb6abd2d3abd7e7d38a71a7ea78bbd9c272e9f1 (origin/master, origin/HEAD)
Author: Dodji Seketeli <dodji@redhat.com>
Date: Fri Mar 31 14:03:53 2023 +0200
Fix redundancy filtering of range types
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (7 preceding siblings ...)
2023-04-02 3:00 ` woodard at redhat dot com
@ 2023-04-06 11:20 ` dodji at redhat dot com
2023-04-06 11:21 ` dodji at redhat dot com
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dodji at redhat dot com @ 2023-04-06 11:20 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |29360
Referenced Bugs:
https://sourceware.org/bugzilla/show_bug.cgi?id=29360
[Bug 29360] Ada ranges emitting/reading/diffing are not supported in libabigail
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (8 preceding siblings ...)
2023-04-06 11:20 ` dodji at redhat dot com
@ 2023-04-06 11:21 ` dodji at redhat dot com
2023-04-06 11:27 ` dodji at redhat dot com
2023-04-07 18:16 ` dodji at redhat dot com
11 siblings, 0 replies; 13+ messages in thread
From: dodji at redhat dot com @ 2023-04-06 11:21 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |29360
Depends on|29360 |
Referenced Bugs:
https://sourceware.org/bugzilla/show_bug.cgi?id=29360
[Bug 29360] Ada ranges emitting/reading/diffing are not supported in libabigail
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (9 preceding siblings ...)
2023-04-06 11:21 ` dodji at redhat dot com
@ 2023-04-06 11:27 ` dodji at redhat dot com
2023-04-07 18:16 ` dodji at redhat dot com
11 siblings, 0 replies; 13+ messages in thread
From: dodji at redhat dot com @ 2023-04-06 11:27 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #7 from dodji at redhat dot com ---
I have committed these patches to the mainline recently:
97d5ae80 dwarf-reader: Support DW_OP_GNU_variable_value
eb272db9 reader: Make reader::get_scope_for_node handle subranges at array
scope.
5a6c04c8 abipkgdiff: Don't use user-specific filesystem info in error msg
fee06608 dwarf-reader: Support Ada subranges having upper_bound < lower_bound
These come on top of the commit you mentioned above:
ddb6abd2 Fix redundancy filtering of range types
These fixed the support for the following packages:
aws, ghdl, gnatcoll-core, GtkAda3, GtkAda, matreshka-amf, templates_parser and
xmlada.
The package gprbuild, however, is still not supported. I am still working on
that one.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug default/29333] fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ada
2022-07-08 2:37 [Bug default/29333] New: fedabipkgdiff --self-compare asserts on Gtk3Ada and Gtk3Ad2 woodard at redhat dot com
` (10 preceding siblings ...)
2023-04-06 11:27 ` dodji at redhat dot com
@ 2023-04-07 18:16 ` dodji at redhat dot com
11 siblings, 0 replies; 13+ messages in thread
From: dodji at redhat dot com @ 2023-04-07 18:16 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=29333
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from dodji at redhat dot com ---
(In reply to dodji from comment #7)
> I have committed these patches to the mainline recently:
>
> 97d5ae80 dwarf-reader: Support DW_OP_GNU_variable_value
> eb272db9 reader: Make reader::get_scope_for_node handle subranges at array
> scope.
> 5a6c04c8 abipkgdiff: Don't use user-specific filesystem info in error msg
> fee06608 dwarf-reader: Support Ada subranges having upper_bound <
> lower_bound
>
> These come on top of the commit you mentioned above:
>
> ddb6abd2 Fix redundancy filtering of range types
>
> These fixed the support for the following packages:
>
> aws, ghdl, gnatcoll-core, GtkAda3, GtkAda, matreshka-amf, templates_parser
> and xmlada.
>
> The package gprbuild, however, is still not supported. I am still working
> on that one.
The package gprbuild now self-compares.
This is with this commit:
ff8cba87 dwarf-reader: Support indirectly referenced subrange_type DIEs
I think libabigail can now analyze all these Ada packages.
So I am closing this bug.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 13+ messages in thread