public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "gprocida at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29568] New: abidiff - misses diffs in highly connected ABI
Date: Tue, 13 Sep 2022 10:36:39 +0000	[thread overview]
Message-ID: <bug-29568-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=29568

            Bug ID: 29568
           Summary: abidiff - misses diffs in highly connected ABI
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 14332
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14332&action=edit
test case files

Hi Dodji.

While doing some performance tests, I found an abidiff issue (with an older
version of libabigail).

The attached test case includes two XML files which are almost but not quite
identical.

I've written up the reproducible test case as a script (though there is a
chance that type ids won't quite match match what sed expects depending on the
exact build of abidw). In any case you can examine and diff the XML files "by
hand".

abidiff should report a diff but does not. --harmless makes no difference.

I'm not sure if the "connectedness" of the ABIs is significant.

This "old" abidiff performance is fine here, BTW, but current libabigail is
very slow. So you could also use this example for performance testing abidiff.
I don't actually know how long it takes to run as it's still running as I type
this. I suppose it's possible that current libabigail does find the diff... in
which case this is a performance bug instead. I'll follow up if/when it
terminates.

Regards,
Giuliano.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2022-09-13 10:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 10:36 gprocida at google dot com [this message]
2022-09-13 11:05 ` [Bug default/29568] abidiff - performance regression gprocida at google dot com
2022-09-13 11:20 ` gprocida at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29568-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).