public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/29733] Comparing 2.0 dump to 2.1 dump: parameter 1 of type 'int' was added to destructor
Date: Thu, 01 Dec 2022 11:09:14 +0000	[thread overview]
Message-ID: <bug-29733-9487-CEXGUMbnWd@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-29733-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=29733

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTABUG
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from dodji at redhat dot com ---
Hello,

I think the behaviour you are seeing is due to this commit that happened in the
2.1 version, indeed:

https://sourceware.org/git/?p=libabigail.git;a=commit;h=861e4670b611b2f95d69f68bb1edaa15ab5f3aa5.

Long story short, that commit introduced a (minor) incompatibility in the abi
dumps due to a fix in the handling of cloned functions.  Cloned functions is
how some compilers (like GCC) handle the implementation of the different kinds
of destructor functions.  With that fix, libabigail better represents all
cloned functions in its IR. That is why you are seeing more destructors in the
ABI dump.

I bumped the version number of ABIXML to say that users, like yourself, who
rely on abi dumps need to re-generate those dumps with the new version of
libabigail if they want to perform comparisons of the dumps, as opposed to
comparing the binaries directly.

So, long story even shorter, I think the solution would be to regenerate the
dumps with the 2.1 version.  I try to avoid those abixml version bumps, but
sometimes they are necessary, sadly.

Sorry for the inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2022-12-01 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31  8:41 [Bug default/29733] New: " dermojo at gmail dot com
2022-10-31  8:42 ` [Bug default/29733] " dermojo at gmail dot com
2022-10-31  8:42 ` dermojo at gmail dot com
2022-12-01 11:09 ` dodji at redhat dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-29733-9487-CEXGUMbnWd@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).