[Bug default/29901] New: abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[Bug default/29901] New: abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

            Bug ID: 29901
           Summary: abidiff hangs when comparing freshly-built libgs.so.10
                    with itself (runs for hours)
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: sam at gentoo dot org
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 14519
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14519&action=edit
backtrace from hanging (few minutes)

Sorry for the lack of detail, I'm not sure how to describe this properly yet.

In Gentoo, we have tooling for developers to use abidiff when upgrading
packages or changing build options, which is a great convenience. It compares
the system copy with the version just built. Thanks for libabigail, it's a huge
help.

With ghostscript-gpl-10.0.0, libabigail's abidiff seems to hang when doing this
comparison (had been running for an hour at this point):
```
root     2761321 97.6  1.8 1360832 1242480 pts/1 RN+  02:40  55:22 abidiff
--stats --d1 /usr/lib/debug --d2
/var/tmp/portage/app-text/ghostscript-gpl-10.0.0-r4/image/usr/lib/debug
/usr/lib64/libgs.so.10.00
/var/tmp/portage/app-text/ghostscript-gpl-10.0.0-r4/image/usr/lib64/libgs.so.10.00
```

Same happens without --stats.

$ abidiff --version
abidiff: 2.2.0

Attached backtrace after running for about 3-4 minutes on a fresh run. Sorry
it's not from a longer run, I can grab one of those if needed. Let me know if &
how to grab more info. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29901] abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

--- Comment #1 from Sam James <sam at gentoo dot org> ---
Sorry, I obviously should've provided two binaries as well. I'll upload them
later today.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29901] abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from dodji at redhat dot com ---
Hello,

I have been looking at bug
https://sourceware.org/bugzilla/show_bug.cgi?id=29857 and I think that the
patch I am working on there should fix this one as well.

But to be sure of that, I'd need to get my hand on the binaries you are looking
at.  Would that be possible, please?

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29901] abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

--- Comment #3 from Sam James <sam at gentoo dot org> ---
(In reply to dodji from comment #2)
> Hello,
> 
> I have been looking at bug
> https://sourceware.org/bugzilla/show_bug.cgi?id=29857 and I think that the
> patch I am working on there should fix this one as well.
> 
> But to be sure of that, I'd need to get my hand on the binaries you are
> looking at.  Would that be possible, please?
> 
> Thanks.

Sorry for the delay! Here it is (too large to attach to bugzilla, hope that's
alright):
https://dev.gentoo.org/~sam/bugs/sourceware/29901/libabigail-bug.tar.xz

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29901] abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

--- Comment #4 from dodji at redhat dot com ---
(In reply to Sam James from comment #3)

[...]

> Sorry for the delay!

No problem.

> Here it is (too large to attach to bugzilla, hope
> that's alright):
> https://dev.gentoo.org/~sam/bugs/sourceware/29901/libabigail-bug.tar.xz

I could get it.  Thank you.

However, the debug info of each binary (libgs.so.10.00 and libgs.so.10.00.new)
are split out into separate debuginfo files.  Those files must be somewhere
(probably under /usr/lib/debug) on your system and are named
"libgs.so.10.00.debug". 

I need those debug files to reproduce the issue.

Could you please provide them as well?

Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29901] abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

--- Comment #5 from Sam James <sam at gentoo dot org> ---
My apologies -- obvious in retrospect!

Please try again at the same link.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29901] abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |ASSIGNED

--- Comment #6 from dodji at redhat dot com ---
(In reply to Sam James from comment #5)
> My apologies -- obvious in retrospect!

No problem, and thank you for following up.

> Please try again at the same link.

I got it now, thanks.  Looking into it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29901] abidiff hangs when comparing freshly-built libgs.so.10 with itself (runs for hours)

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29901

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from dodji at redhat dot com ---
This problem should hopefully be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=e1aadfa576963f2baddc6b6bf17898a86e3a041e.

On my machine, the comparison now ends up in about less than 45minutes.  This
is still a lot, but at least there is no more infinite loop.

This fix should be available in libabigail 2.3.

Thank you taking the time to report this problem and sorry for the
inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.