[Bug default/29978] New: fedabipkgdiff --self-compare -a --from fc37 evolution-data-server-tests has problems

[Bug default/29978] New: fedabipkgdiff --self-compare -a --from fc37 evolution-data-server-tests has problems

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29978

            Bug ID: 29978
           Summary: fedabipkgdiff --self-compare -a --from fc37
                    evolution-data-server-tests has problems
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

$ fedabipkgdiff --self-compare --dry-run -a --from fc37
evolution-data-server-tests
has a couple of problems. One problem is:

$ abipkgdiff --self-check  --d1
/home/ben/.cache/fedabipkgdiff/downloads/evolution-data-server-tests-debuginfo-3.46.3-1.fc37.aarch64.rpm
/home/ben/.cache/fedabipkgdiff/downloads/evolution-data-server-tests-3.46.3-1.fc37.aarch64.rpm
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-SavAlX/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-book-cache-offline.abi:262:
parser error : Specification mandates value for attribute la
      <data-member access='public' laELF
                                     ^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-SavAlX/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-book-cache-offline.abi:262:
parser error : attributes construct error
      <data-member access='public' laELF
                                     ^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-SavAlX/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-book-cache-offline.abi:262:
parser error : Couldn't find end of Start Tag data-member
      <data-member access='public' laELF
                                     ^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-SavAlX/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-ebook-get-contact.abi:315:
parser error : AttValue: ' expected
ug/evolution-data-server-3.46.3-1.fc37.aarch64/tests/libebook/ebook-test-utils.c
                                                                              
^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-SavAlX/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-ebook-get-contact.abi:315:
parser error : attributes construct error
ug/evolution-data-server-3.46.3-1.fc37.aarch64/tests/libebook/ebook-test-utils.c
                                                                              
^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-SavAlX/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-ebook-get-contact.abi:315:
parser error : Couldn't find end of Start Tag parameter
ug/evolution-data-server-3.46.3-1.fc37.aarch64/tests/libebook/ebook-test-utils.c
                                                                              
^
<snip>
abipkgdiff: ../../../libabigail/tools/abipkgdiff.cc:1651:
abigail::tools_utils::abidiff_status compare_to_self(const elf_file&, const
std::string&, const options&, abigail::ir::environment&,
abigail::comparison::corpus_diff_sptr&,
abigail::comparison::diff_context_sptr&, abigail::fe_iface::status*): Assertion
`__abg_cond__' failed.
Aborted (core dumped)

running under GDB doesn't give a backtrace but I do get:

/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-mvfgw3/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-cal-client-create-object.abi:99:
parser error : AttValue: ' expected
    <class-decl name='_ICalObject
                                 ^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-mvfgw3/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-cal-client-create-object.abi:99:
parser error : attributes construct error
    <class-decl name='_ICalObject
                                 ^
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-mvfgw3/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-cal-client-create-object.abi:99:
parser error : Couldn't find end of Start Tag class-decl
    <class-decl name='_ICalObject
                                 ^
I/O error : Bad file descriptor
/home/ben/.cache/libabigail/abipkgdiff-tmp-dir-mvfgw3/package1/abixml/usr/libexec/evolution-data-server/installed-tests/test-cal-client-add-timezone.abi:1:
parser error : Extra content at the end of the document

^
I/O error : Bad file descriptor
I/O error : Bad file descriptor

Which is different than the previous error when not running under gdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29978] fedabipkgdiff --self-compare -a --from fc37 evolution-data-server-tests has problems

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29978

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
running through all the commands emitted by
$ fedabipkgdiff --self-compare --dry-run -a --from fc37
evolution-data-server-tests

They seem to assert inconsistently but reliably when run from fedabipkgdiff.
However, the other problem with the data inconsistency or proper escaping may
be related.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29978] fedabipkgdiff --self-compare -a --from fc37 evolution-data-server-tests has problems

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29978

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
This is with the latest trunk as of 5d97da97

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29978] fedabipkgdiff --self-compare -a --from fc37 evolution-data-server-tests has problems

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29978

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29412

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
I'm going to link this one to the assert metabug even though it is hard to
reproduce.


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29412
[Bug 29412] libabigail 2.2 Assertion metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/29978] fedabipkgdiff --self-compare -a --from fc37 evolution-data-server-tests has problems

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29978

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from dodji at redhat dot com ---
Hello,

This one appears to be fixed in recent master, at least from this commit:

e9e38dc1 ir: Fix cycle detection for union types

Here is what I am seeing (after all the packages were downloaded):

$ time fedabipkgdiff --abipkgdiff ../../build/tools/abipkgdiff --self-compare
-a --from fc37 evolution-data-server-tests

[...]

real    0m20,508s
user    0m27,283s
sys     0m37,544s

$ 

So, I am tentatively closing this for now.

Thank you for having taken the time to file this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.