public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/30034] [libabigail] Handle library splitting
Date: Tue, 06 Jun 2023 21:07:01 +0000	[thread overview]
Message-ID: <bug-30034-9487-l0wMY1jjuF@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-30034-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=30034

--- Comment #9 from Ben Woodard <woodard at redhat dot com> ---
my original for abicompat was to add --recursive I'm no longer convinced that I
like that idea. I like the --follow-dependencies or even making that the
default and have --exclude-dependencies. 

Right now we support:

  FILE_TYPE_XML_TU, (formerly called FILE_TYPE_NATIVE_BI) 
  FILE_TYPE_ELF,
  FILE_TYPE_AR,
  FILE_TYPE_XML_CORPUS,
  FILE_TYPE_XML_CORPUS_GROUP,
  FILE_TYPE_RPM,
  FILE_TYPE_SRPM,
  FILE_TYPE_DEB,
  FILE_TYPE_DIR,
  FILE_TYPE_TAR

What I'm thinking is:

abidw currently either emits FILE_TYPE_XML_CORPUS or FILE_TYPE_XML_CORPUS_GROUP
in the case of a kernel. 

I think it should work like this:

 * normal.o -> FILE_TYPE_XML_TU or by explicit request promotion to
FILE_TYPE_XML_CORPUS or even FILE_TYPE_XML_CORPUS_GROUP
 * elffile -> FILE_TYPE_XML_CORPUS_GROUP which includes dependencies or by
explicit request FILE_TYPE_XML_CORPUS without dependencies. Note that this is a
change of behavior. Right now   libabigail emits a corpus and only emits
FILE_TYPE_XML_CORPUS_GROUP when it given a directory and a kernel vmlinux file.
 * archive, tar, rpm, deb, dir, or multiple files -> FILE_TYPE_XML_CORPUS_GROUP

I think for completeness sake abidw should also allow some up and down
conversion

 * FILE_TYPE_XML_TU can be promoted to FILE_TYPE_XML_CORPUS (with one TU) or
FILE_TYPE_XML_CORPUS_GROUP (with one TU and a group size of 1)
 * FILE_TYPE_XML_CORPUS 
     * can be promoted to FILE_TYPE_XML_CORPUS_GROUP with a group size of 1
     * can be down converted to FILE_TYPE_XML_TU by specifying the TU to
extract.
 * FILE_TYPE_XML_CORPUS_GROUP
     * can be down converted to FILE_TYPE_XML_CORPUS if the size of the group
is 1 or by specifying the specific corpus to extract. 
     * can be down converted to FILE_TYPE_XML_TU if the size of the group is 1
and the TU to extract is specified or by specifying the corpus and the tu
within it to extract.

Lastly allowing abidw to accept its own xml formats allows additional
suppressions to be applied to the abi.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2023-06-06 21:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 13:45 [Bug default/30034] New: " david.marchand at redhat dot com
2023-06-02 17:53 ` [Bug default/30034] " dodji at redhat dot com
2023-06-05  8:04 ` david.marchand at redhat dot com
2023-06-05 11:01 ` dodji at redhat dot com
2023-06-05 15:08 ` david.marchand at redhat dot com
2023-06-05 15:24 ` woodard at redhat dot com
2023-06-05 15:36 ` dodji at redhat dot com
2023-06-05 16:53 ` woodard at redhat dot com
2023-06-06  7:28 ` david.marchand at redhat dot com
2023-06-06 21:07 ` woodard at redhat dot com [this message]
2023-06-09 12:29 ` dodji at redhat dot com
2023-06-14 12:22 ` david.marchand at redhat dot com
2023-06-23  8:30 ` david.marchand at redhat dot com
2023-06-23  8:32 ` david.marchand at redhat dot com
2023-06-23 10:17 ` david.marchand at redhat dot com
2023-06-24 14:19 ` dodji at redhat dot com
2023-06-24 14:32 ` dodji at redhat dot com
2023-06-25  8:17 ` david.marchand at redhat dot com
2023-06-25  8:37 ` david.marchand at redhat dot com
2023-06-26 10:07 ` dodji at redhat dot com
2023-06-26 10:11 ` dodji at redhat dot com
2023-06-26 12:13 ` david.marchand at redhat dot com
2023-06-26 12:41 ` david.marchand at redhat dot com
2023-06-26 13:57 ` dodji at redhat dot com
2023-07-06 13:38 ` david.marchand at redhat dot com
2023-07-07  8:38   ` Dodji Seketeli
2023-07-07  8:39 ` dodji at seketeli dot org
2023-07-07 11:48 ` dodji at redhat dot com
2023-07-07 13:55 ` fweimer at redhat dot com
2023-07-07 18:18 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-30034-9487-l0wMY1jjuF@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).