[Bug default/30034] [libabigail] Handle library splitting

["david.marchand at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30034

--- Comment #23 from David Marchand <david.marchand at redhat dot com> ---
For the record, before I go off for some weeks.

I tried:
$ git describe
libabigail-2.3-18-g91682eaf
$ git ll | head -3
91682eaf - (HEAD -> PR30034, origin/users/dodji/try-PR30034,
origin/users/dodji/PR30034) abidiff: Add --{follow,list}-dependencies &
add-binaries{1,2} support (47 minutes ago) <Dodji Seketeli>
daba3581 - abidw: Add --{follow,list}-dependencies & --add-binaries= support
(47 minutes ago) <Dodji Seketeli>
a72b5046 - corpus,tools-utils: Support loading a corpus, its deps & other
binaries (47 minutes ago) <Dodji Seketeli>


- You may want to fix typos (invalid -to suffix in the options) in the README
file:
README-ABIDIFF-BINARIES-SET-SUPPORT.md:    $ abidiff
--add-binaries-to1=file2-v1           \
README-ABIDIFF-BINARIES-SET-SUPPORT.md:             
--add-binaries-to2=file2-v2,file2-v1  \

- The mandatory aspect of the --add-binaries-toX options is disturbing, but it
seems to work if I pass an empty list --add-binaries-to1=

- Requiring a '=' for those --add-binariesX options is surprising as other
options won't accept a =.

- Now performance / runtime wise, before the DPDK split:
* before the DPDK split, with 2.2 libabigail package from fc37:
real    0m2,233s
user    0m20,185s
sys     0m2,354s
* before the DPDK split, with libabigail binaries generated against this branch
and no change in abidiff runtime:
real    0m2,414s
user    0m21,802s
sys     0m3,502s

And with the DPDK split:
* using --follow-dependencies + --add-binaries-dirX:
real    0m20,935s
user    3m4,397s
sys     1m45,828s
* using --add-binaries1= --add-binaries2=librte_log.so + --add-binaries-dirX:
real    0m2,703s
user    0m24,006s
sys     0m4,458s

Which seems acceptable to me :-).

-- 
You are receiving this mail because:
You are on the CC list for the bug.