[Bug default/30274] RFE have fedabipkgdiff prefer debuginfod when available

["fche at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=30274

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
fedabipkgdiff does a busy loop on waitpid() on the abipkgdiff child process:

@log_call
def abipkgdiff(cmp_half1, cmp_half2):
    [...]
    proc = subprocess.Popen(' '.join(cmd), shell=True,
                            stdout=subprocess.PIPE, stderr=subprocess.PIPE,
                            universal_newlines=True)
    # So we could have done: stdout, stderr = proc.communicate()
    # But then the documentatin of proc.communicate says:
    #
    #    Note: The data read is buffered in memory, so do not use this
    #    method if the data size is large or unlimited. "
    #
    # In practice, we are seeing random cases where this
    # proc.communicate() function does *NOT* terminate and seems to be
    # in a deadlock state.  So we are avoiding it altogether.  We are
    # then busy looping, waiting for the spawn process to finish, and
    # then we get its output.
    #

    while True:
        if proc.poll() != None:
            break


Not sure that interpretation of python docs is correct, but even then, a wee
bit of sleep wouldn't hurt.

-- 
You are receiving this mail because:
You are on the CC list for the bug.