public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/30461] New: insight fails self-compare
@ 2023-05-18 19:19 woodard at redhat dot com
  2023-05-18 19:19 ` [Bug default/30461] " woodard at redhat dot com
  2023-06-22  7:58 ` dodji at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: woodard at redhat dot com @ 2023-05-18 19:19 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=30461

            Bug ID: 30461
           Summary: insight fails self-compare
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

It was mentioned in several places before but thought to be one of the other
bugs many of which are closed. However, insight seems to be a problem that
stands on its own.

fedabipkgdiff --self-compare -a --from fc38 insight
Comparing the ABI of binaries between
insight-13.0.50.20220502-9.fc38.aarch64.rpm and
insight-13.0.50.20220502-9.fc38.aarch64.rpm:

==== SELF CHECK SUCCEEDED for 'insight' ====

Comparing the ABI of binaries between insight-13.0.50.20220502-9.fc38.i686.rpm
and insight-13.0.50.20220502-9.fc38.i686.rpm:

================ changes of 'insight'===============
  Functions changes summary: 0 Removed, 1 Changed (8 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

  1 function with some indirect sub-type change:

    [C] 'function ps_err_e ps_get_thread_area(ps_prochandle*, lwpid_t, int,
void**)' at i386-linux-nat.c:604:1 has some indirect sub-type changes:
      parameter 1 of type 'ps_prochandle*' has sub-type changes:
        in pointed to type 'struct ps_prochandle' at gdb_proc_service.h:27:1:
          type size hasn't changed
          1 data member change:
            type of 'thread_info* thread' changed:
              in pointed to type 'struct thread_info' at gdbthread.h:244:1:
                type size hasn't changed
                no base class change (1 filtered);
                1 data member changes (8 filtered):
                  type of 'inferior* inf' changed:
                    in pointed to type 'struct inferior' at inferior.h:347:1:
                      type size hasn't changed
                      no base class change (1 filtered);
                      1 data member changes (6 filtered):
                        type of 'program_space* pspace' changed:
                          in pointed to type 'struct program_space' at
progspace.h:191:1:
                            type size hasn't changed
                            1 data member changes (6 filtered):
                              type of 'gdb_bfd_ref_ptr ebfd' changed:
                                underlying type 'class gdb::ref_ptr<bfd,
gdb_bfd_ref_policy>' at gdb_ref_ptr.h:49:1 changed:
                                  type size hasn't changed
                                  1 data member change:
                                    type of 'bfd* m_obj' changed:
                                      in pointed to type 'struct bfd' at
bfd.h:6533:1:
                                        type size hasn't changed
                                        1 data member changes (13 filtered):
                                          type of 'const bfd_target* xvec'
changed:
                                            in pointed to type 'const
bfd_target':
                                              in unqualified underlying type
'struct bfd_target' at bfd.h:7376:1:
                                                type size hasn't changed
                                                1 data member changes (78
filtered):
                                                  type of 'bool (bfd*)*
_bfd_set_format[4]' changed:
                                                    array element type 'bool
(bfd*)*' changed:
                                                      in pointed to type
'function type bool (bfd*)':
                                                        parameter 1 of type
'bfd*' has sub-type changes:
                                                          in pointed to type
'typedef bfd' at bfd.h:99:1:
                                                            underlying type
'struct bfd' at bfd.h:6533:1 changed:
                                                              type size hasn't
changed
                                                              2 data member
changes (12 filtered):
                                                                type of 'const
bfd_target* xvec' changed:
                                                                  in pointed to
type 'const bfd_target':
                                                                    in
unqualified underlying type 'struct bfd_target' at bfd.h:7376:1:
                                                                      type size
hasn't changed
                                                                      2 data
member changes (77 filtered):
                                                                        type of
'int (bfd*)* _core_file_failing_signal' changed:
                                                                          in
pointed to type 'function type int (bfd*)':
                                                                           
parameter 1 of type 'bfd*' has sub-type changes:
                                                                             
in pointed to type 'typedef bfd' at bfd.h:6533:1:
                                                                               
entity changed from 'typedef bfd' to compatible type 'struct bfd' at
bfd.h:6533:1
                                                                        type of
'int (bfd*, stat*)* _bfd_stat_arch_elt' changed:
                                                                          in
pointed to type 'function type int (bfd*, stat*)':
                                                                           
parameter 2 of type 'stat*' has sub-type changes:
                                                                             
in pointed to type 'struct stat' at struct_stat.h:26:1:
                                                                               
type size changed from 864 to 768 (in bits)
                                                                               
3 data member insertions:
                                                                               
  'unsigned short int __pad1', at offset 64 (in bits) at struct_stat.h:33:1
                                                                               
  '__ino_t __st_ino', at offset 96 (in bits) at struct_stat.h:38:1
                                                                               
  'unsigned short int __pad2', at offset 320 (in bits) at struct_stat.h:54:1
                                                                               
7 data member changes:
                                                                               
  '__ino64_t st_ino' offset changed from 64 to 704 (in bits) (by +640 bits)
                                                                               
  '__off64_t st_size' offset changed from 320 to 352 (in bits) (by +32 bits)
                                                                               
  '__blksize_t st_blksize' offset changed from 384 to 416 (in bits) (by +32
bits)
                                                                               
  '__blkcnt64_t st_blocks' offset changed from 416 to 448 (in bits) (by +32
bits)
                                                                               
  type of 'timespec st_atim' changed:
                                                                               
    type size changed from 128 to 64 (in bits)
                                                                               
    2 data member changes:
                                                                               
      type of '__time64_t tv_sec' changed:
                                                                               
        typedef name changed from __time64_t to __time_t at types.h:160:1
                                                                               
        underlying type 'typedef __int64_t' at types.h:47:1 changed:
                                                                               
          entity changed from 'typedef __int64_t' to compatible type 'long int'
                                                                               
            type name changed from 'long long int' to 'long int'
                                                                               
            type size changed from 64 to 32 (in bits)
                                                                               
      'long int tv_nsec' offset changed from 64 to 32 (in bits) (by -32 bits)
                                                                               
  and offset changed from 480 to 512 (in bits) (by +32 bits)
                                                                               
  'timespec st_mtim' offset changed from 608 to 576 (in bits) (by -32 bits),
size changed from 128 to 64 (in bits) (by -64 bits)
                                                                               
  'timespec st_ctim' offset changed from 736 to 640 (in bits) (by -96 bits),
size changed from 128 to 64 (in bits) (by -64 bits)
                                                                type of 'bfd*
plugin_dummy_bfd' changed:
                                                                  in pointed to
type 'struct bfd' at bfd.h:99:1:
                            1 data member changes (6 filtered):
                              type of 'gdb_bfd_ref_ptr ebfd' changed:
                                underlying type 'class gdb::ref_ptr<bfd,
gdb_bfd_ref_policy>' at gdb_ref_ptr.h:49:1 changed:
                                  type size hasn't changed
                                  1 data member change:
                                    type of 'bfd* m_obj' changed:
                                      in pointed to type 'struct bfd' at
bfd.h:6533:1:
                                        type size hasn't changed
                                        1 data member changes (13 filtered):
                                          type of 'const bfd_target* xvec'
changed:
                                            in pointed to type 'const
bfd_target':
                                              in unqualified underlying type
'struct bfd_target' at bfd.h:7376:1:
                                                type size hasn't changed
                                                1 data member changes (78
filtered):
                                                  type of 'bool (bfd*)*
_bfd_set_format[4]' changed:
                                                    array element type 'bool
(bfd*)*' changed:
                                                      in pointed to type
'function type bool (bfd*)':
                                                        parameter 1 of type
'bfd*' has sub-type changes:
                                                          in pointed to type
'typedef bfd' at bfd.h:99:1:
                                                            underlying type
'struct bfd' at bfd.h:6533:1 changed:
                                                              type size hasn't
changed
                                                              2 data member
changes (12 filtered):
                                                                type of 'const
bfd_target* xvec' changed:
                                                                  in pointed to
type 'const bfd_target':
                                                                    in
unqualified underlying type 'struct bfd_target' at bfd.h:7376:1:
                                                                      type size
hasn't changed
                                                                      2 data
member changes (77 filtered):
                                                                        type of
'int (bfd*)* _core_file_failing_signal' changed:
                                                                          in
pointed to type 'function type int (bfd*)':
                                                                           
parameter 1 of type 'bfd*' has sub-type changes:
                                                                             
in pointed to type 'typedef bfd' at bfd.h:6533:1:
                                                                               
entity changed from 'typedef bfd' to compatible type 'struct bfd' at
bfd.h:6533:1
                                                                        type of
'int (bfd*, stat*)* _bfd_stat_arch_elt' changed:
                                                                          in
pointed to type 'function type int (bfd*, stat*)':
                                                                           
parameter 2 of type 'stat*' has sub-type changes:
                                                                             
in pointed to type 'struct stat' at struct_stat.h:26:1:
                                                                               
type size changed from 864 to 768 (in bits)
                                                                               
3 data member insertions:
                                                                               
  'unsigned short int __pad1', at offset 64 (in bits) at struct_stat.h:33:1
                                                                               
  '__ino_t __st_ino', at offset 96 (in bits) at struct_stat.h:38:1
                                                                               
  'unsigned short int __pad2', at offset 320 (in bits) at struct_stat.h:54:1
                                                                               
7 data member changes:
                                                                               
  '__ino64_t st_ino' offset changed from 64 to 704 (in bits) (by +640 bits)
                                                                               
  '__off64_t st_size' offset changed from 320 to 352 (in bits) (by +32 bits)
                                                                               
  '__blksize_t st_blksize' offset changed from 384 to 416 (in bits) (by +32
bits)
                                                                               
  '__blkcnt64_t st_blocks' offset changed from 416 to 448 (in bits) (by +32
bits)
                                                                               
  type of 'timespec st_atim' changed:
                                                                               
    type size changed from 128 to 64 (in bits)
                                                                               
    2 data member changes:
                                                                               
      type of '__time64_t tv_sec' changed:
                                                                               
        typedef name changed from __time64_t to __time_t at types.h:160:1
                                                                               
        underlying type 'typedef __int64_t' at types.h:47:1 changed:
                                                                               
          entity changed from 'typedef __int64_t' to compatible type 'long int'
                                                                               
            type name changed from 'long long int' to 'long int'
                                                                               
            type size changed from 64 to 32 (in bits)
                                                                               
      'long int tv_nsec' offset changed from 64 to 32 (in bits) (by -32 bits)
                                                                               
  and offset changed from 480 to 512 (in bits) (by +32 bits)
                                                                               
  'timespec st_mtim' offset changed from 608 to 576 (in bits) (by -32 bits),
size changed from 128 to 64 (in bits) (by -64 bits)
                                                                               
  'timespec st_ctim' offset changed from 736 to 640 (in bits) (by -96 bits),
size changed from 128 to 64 (in bits) (by -64 bits)
                                                                type of 'bfd*
plugin_dummy_bfd' changed:
                                                                  in pointed to
type 'struct bfd' at bfd.h:99:1:
                                                                    entity
changed from 'struct bfd' to compatible type 'typedef bfd' at bfd.h:99:1
                                                    type size hasn't changed

================ end of changes of 'insight'===============

Interestingly, the changes are only explicitly pointed out on i686 while they
are filtered out on other platforms.

Comparing the ABI of binaries between
insight-13.0.50.20220502-9.fc38.x86_64.rpm and
insight-13.0.50.20220502-9.fc38.x86_64.rpm:

================ changes of 'insight'===============
  Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added
functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

================ end of changes of 'insight'===============

This is with trunk as of:
commit 06e8d54d0404ccf2a103804ec568797822152b69 (HEAD -> master, origin/master,
origin/HEAD)
Author: Dodji Seketeli <dodji@redhat.com>
Date:   Wed May 17 13:44:58 2023 +0200

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/30461] insight fails self-compare
  2023-05-18 19:19 [Bug default/30461] New: insight fails self-compare woodard at redhat dot com
@ 2023-05-18 19:19 ` woodard at redhat dot com
  2023-06-22  7:58 ` dodji at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: woodard at redhat dot com @ 2023-05-18 19:19 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=30461

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29413


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=29413
[Bug 29413] libabigail 2.3 self-compare metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/30461] insight fails self-compare
  2023-05-18 19:19 [Bug default/30461] New: insight fails self-compare woodard at redhat dot com
  2023-05-18 19:19 ` [Bug default/30461] " woodard at redhat dot com
@ 2023-06-22  7:58 ` dodji at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: dodji at redhat dot com @ 2023-06-22  7:58 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=30461

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
This issue should now be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=a69bbac706651c970db690e6d4ed6ad6156fe34b.

The fix should be available in libabigail 2.4.

Thanks for reporting this problem and sorry for the inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-22  7:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-18 19:19 [Bug default/30461] New: insight fails self-compare woodard at redhat dot com
2023-05-18 19:19 ` [Bug default/30461] " woodard at redhat dot com
2023-06-22  7:58 ` dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).