* [Bug default/30503] New: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 @ 2023-06-01 0:33 sam at gentoo dot org 2023-06-01 0:34 ` [Bug default/30503] " sam at gentoo dot org ` (4 more replies) 0 siblings, 5 replies; 6+ messages in thread From: sam at gentoo dot org @ 2023-06-01 0:33 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=30503 Bug ID: 30503 Summary: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 Product: libabigail Version: unspecified Status: NEW Severity: normal Priority: P2 Component: default Assignee: dodji at redhat dot com Reporter: sam at gentoo dot org CC: libabigail at sourceware dot org Target Milestone: --- As discussed on #libabigail a few days ago. ``` $ abidiff --version abidiff: 2.3.0 $ abidiff 1.2.60/lib64/libSDL-1.2.so.1.2.60 1.2.64/lib64/libSDL-1.2.so.1.2.64 Functions changes summary: 0 Removed, 1 Changed (1 filtered out), 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 1 function with some indirect sub-type change: [C] 'function int SDL_BuildAudioCVT(SDL12_AudioCVT*, Uint16, Uint8, int, Uint16, Uint8, int)' at SDL12_compat.c:9383:1 has some indirect sub-type changes: parameter 1 of type 'SDL12_AudioCVT*' has sub-type changes: in pointed to type 'typedef SDL12_AudioCVT' at SDL12_compat.c:920:1: underlying type 'struct SDL12_AudioCVT' at SDL12_compat.c:880:1 changed: type size hasn't changed 11 data member changes: 'int needed' has *some* difference - please report as a bug 'Uint16 src_format' has *some* difference - please report as a bug 'Uint16 dst_format' has *some* difference - please report as a bug 'double rate_incr' has *some* difference - please report as a bug 'Uint8* buf' has *some* difference - please report as a bug 'int len' has *some* difference - please report as a bug 'int len_cvt' has *some* difference - please report as a bug 'int len_mult' has *some* difference - please report as a bug 'double len_ratio' has *some* difference - please report as a bug type of 'void (SDL_AudioCVT*, typedef Uint16)* filters[10]' changed: array element type 'void (SDL_AudioCVT*, typedef Uint16)*' changed: entity changed from 'void (SDL_AudioCVT*, typedef Uint16)*' to compatible type 'typedef SDL12_AudioCVTFilter' at SDL12_compat.c:903:1 in pointed to type 'function type void (SDL_AudioCVT*, typedef SDL_AudioFormat)': parameter 1 of type 'SDL_AudioCVT*' changed: in pointed to type 'struct SDL_AudioCVT' at SDL12_compat.c:907:1: type name changed from 'SDL_AudioCVT' to 'SDL12_AudioCVT' type size changed from 1024 to 1088 (in bits) 3 data member changes (8 filtered): 'double len_ratio' offset changed from 288 to 320 (in bits) (by +32 bits) name of 'SDL_AudioCVT::filters' changed to 'SDL12_AudioCVT::filters' at SDL12_compat.c:918:1, offset changed from 352 to 384 (in bits) (by +32 bits) 'int filter_index' offset changed from 992 to 1024 (in bits) (by +32 bits) type name changed from 'void (SDL_AudioCVT*, typedef Uint16)*[10]' to 'SDL12_AudioCVTFilter[10]' type size hasn't changed 'int filter_index' has *some* difference - please report as a bug ``` I've attached a tarball with the relevant files. I included the 32-bit versions (in lib/) for completeness (because I'd already copied before checking, oops..) but the bug only happens w/ the 64-bit versions (in lib64/): ``` $ tree libsdl-libabigail/ libsdl-libabigail/ ├── 1.2.60 │ ├── lib │ │ ├── libSDL-1.2.so.1.2.60 │ │ └── libSDL-1.2.so.1.2.60.debug │ └── lib64 │ ├── libSDL-1.2.so.1.2.60 │ └── libSDL-1.2.so.1.2.60.debug └── 1.2.64 ├── lib │ ├── libSDL-1.2.so.1.2.64 │ └── libSDL-1.2.so.1.2.64.debug └── lib64 ├── libSDL-1.2.so.1.2.64 └── libSDL-1.2.so.1.2.64.debug 7 directories, 8 files ``` -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/30503] Failure to compare libsdl-1.2.60 and libsdl-1.2.64 2023-06-01 0:33 [Bug default/30503] New: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 sam at gentoo dot org @ 2023-06-01 0:34 ` sam at gentoo dot org 2023-06-05 16:57 ` dodji at redhat dot com ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: sam at gentoo dot org @ 2023-06-01 0:34 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=30503 --- Comment #1 from Sam James <sam at gentoo dot org> --- Tarball at https://dev.gentoo.org/~sam/bugs/sourceware/30503/libsdl-libabigail.tar.xz. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/30503] Failure to compare libsdl-1.2.60 and libsdl-1.2.64 2023-06-01 0:33 [Bug default/30503] New: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 sam at gentoo dot org 2023-06-01 0:34 ` [Bug default/30503] " sam at gentoo dot org @ 2023-06-05 16:57 ` dodji at redhat dot com 2023-06-07 9:57 ` [Bug default/30503] Failure to compare a member of a non-anonymous struct against a member of a typedef-named anonymous struct dodji at redhat dot com ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: dodji at redhat dot com @ 2023-06-05 16:57 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=30503 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from dodji at redhat dot com --- I can reproduce the issue, thank you for reporting this problem. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/30503] Failure to compare a member of a non-anonymous struct against a member of a typedef-named anonymous struct 2023-06-01 0:33 [Bug default/30503] New: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 sam at gentoo dot org 2023-06-01 0:34 ` [Bug default/30503] " sam at gentoo dot org 2023-06-05 16:57 ` dodji at redhat dot com @ 2023-06-07 9:57 ` dodji at redhat dot com 2023-06-07 12:15 ` dodji at redhat dot com 2023-06-07 12:23 ` sam at gentoo dot org 4 siblings, 0 replies; 6+ messages in thread From: dodji at redhat dot com @ 2023-06-07 9:57 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=30503 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Failure to compare |Failure to compare a member |libsdl-1.2.60 and |of a non-anonymous struct |libsdl-1.2.64 |against a member of a | |typedef-named anonymous | |struct -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/30503] Failure to compare a member of a non-anonymous struct against a member of a typedef-named anonymous struct 2023-06-01 0:33 [Bug default/30503] New: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 sam at gentoo dot org ` (2 preceding siblings ...) 2023-06-07 9:57 ` [Bug default/30503] Failure to compare a member of a non-anonymous struct against a member of a typedef-named anonymous struct dodji at redhat dot com @ 2023-06-07 12:15 ` dodji at redhat dot com 2023-06-07 12:23 ` sam at gentoo dot org 4 siblings, 0 replies; 6+ messages in thread From: dodji at redhat dot com @ 2023-06-07 12:15 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=30503 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #3 from dodji at redhat dot com --- This should be fixed by commit https://sourceware.org/git/?p=libabigail.git;a=commit;h=7b565f399e5b5d9bc3a6ce3cbaa944a5d39b85b2. The fix should be available in libabigail 2.4. Thank you for reporting this problem and sorry for the inconvenience. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug default/30503] Failure to compare a member of a non-anonymous struct against a member of a typedef-named anonymous struct 2023-06-01 0:33 [Bug default/30503] New: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 sam at gentoo dot org ` (3 preceding siblings ...) 2023-06-07 12:15 ` dodji at redhat dot com @ 2023-06-07 12:23 ` sam at gentoo dot org 4 siblings, 0 replies; 6+ messages in thread From: sam at gentoo dot org @ 2023-06-07 12:23 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=30503 --- Comment #4 from Sam James <sam at gentoo dot org> --- (In reply to dodji from comment #3) > This should be fixed by commit > https://sourceware.org/git/?p=libabigail.git;a=commit; > h=7b565f399e5b5d9bc3a6ce3cbaa944a5d39b85b2. > > The fix should be available in libabigail 2.4. > > Thank you for reporting this problem and sorry for the inconvenience. Thank you! But please don't apologise. libabigail is a wonderful tool and it's saved me many times. Thank you for maintaining it :) -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-07 12:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-06-01 0:33 [Bug default/30503] New: Failure to compare libsdl-1.2.60 and libsdl-1.2.64 sam at gentoo dot org 2023-06-01 0:34 ` [Bug default/30503] " sam at gentoo dot org 2023-06-05 16:57 ` dodji at redhat dot com 2023-06-07 9:57 ` [Bug default/30503] Failure to compare a member of a non-anonymous struct against a member of a typedef-named anonymous struct dodji at redhat dot com 2023-06-07 12:15 ` dodji at redhat dot com 2023-06-07 12:23 ` sam at gentoo dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).