[Bug default/31377] New: [libabigail] abidiff does not handle some flex array conversion

[Bug default/31377] New: [libabigail] abidiff does not handle some flex array conversion

[david.marchand at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31377

            Bug ID: 31377
           Summary: [libabigail] abidiff does not handle some flex array
                    conversion
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: david.marchand at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Following a tentative change submitted by a DPDK contributor, like

-       __extension__ uint8_t action_data[0];
+       uint8_t action_data[];

our ABI check raised a libabigail exception:

  type size hasn't changed
  1 data member change:
    'uint8_t action_data[]' has *some* difference - please report as a bug

So I am following the suggestion, and reporting a bug :-).
Binaries and commandline can be found in the archive attached to this bz.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31377] [libabigail] abidiff does not handle some flex array conversion

[david.marchand at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31377

--- Comment #1 from David Marchand <david.marchand at redhat dot com> ---
Created attachment 15360
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15360&action=edit
bz31377.tar.xz

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31377] [libabigail] abidiff does not handle some flex array conversion

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31377

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from dodji at redhat dot com ---
I could reproduce the issue, thanks for reporting this problem and sorry for
the inconvenience.

I am looking into it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31377] [libabigail] abidiff does not handle some flex array conversion

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31377

--- Comment #3 from dodji at redhat dot com ---
I am currently testing the patch at the top of the branch
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/PR31377
which is
https://sourceware.org/git/?p=libabigail.git;a=commit;h=3cc1c3423c89c2cfd9d451ab99b71f3a74b35127.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31377] [libabigail] abidiff does not handle some flex array conversion

[david.marchand at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31377

--- Comment #4 from David Marchand <david.marchand at redhat dot com> ---
I tested this PR31377 branch with DPDK binaries and it seems fine.
Thanks for the quick fix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31377] [libabigail] abidiff does not handle some flex array conversion

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31377

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from dodji at redhat dot com ---
The fix for this issue has been applied to the mainline branch at
https://sourceware.org/git/?p=libabigail.git;a=commit;h=3cc1c3423c89c2cfd9d451ab99b71f3a74b35127
and should be available in either libabigail 2.4.1 (if roll such a release out)
or 2.5.


Thank you for reporting this problem and for testing the candidate fix in such
a timely manner.

-- 
You are receiving this mail because:
You are on the CC list for the bug.