public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/31513] abidiff differences due to change in compiler version
Date: Wed, 20 Mar 2024 19:14:07 +0000	[thread overview]
Message-ID: <bug-31513-9487-y7HZPD3aok@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31513-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31513

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |woodard at redhat dot com

--- Comment #5 from Ben Woodard <woodard at redhat dot com> ---
As a person who has done a lot of testing like this:

Ques 1: Is this behavior expected as we have not made any change in the source
files of the library the highlighted changes are in compiler source files.

"is this behavior expected" is a tricky question. As a person who has done a
lot of this testing. I would say that that this behavior is "expected" in the
sense that I do not at all find it surprising.  On the other hand, is this
behavior "desired", no not really. Here is the thing, libabigail pulls its
information from a combination of DWARF and ELF and while ELF pretty much is
needed to make things work and if it isn't "right" the program doesn't run.
DWARF on the other hand has been more or less an afterthought and if things
were not correct then *shrug*. The feeling was it wasn't a critical problem if
debuggers didn't work perfectly in all cases. Tools such as libabigail, stress
the DWARF in new ways and have uncovered quite a few compiler bugs over the
years. We work closely with the compiler people and have resolved many issues
as they have come up. 

So with compilers as far apart as 7.5.0 and 11.4.0 I think it is pretty fair to
assume that we found and fixed quite a few problems between those two releases
and some of the differences are false errors due to problems with the DWARF
emitted by the compiler. The fact that the problems end up showing up in part
of the stdlib also is suggestive that they are more a problem with DWARF than a
problem with your library's ABI changing. 

That being said, there may be some changes in how the templates in the headers
that make up that part of the standard library are instantiated based on the
compiler version or supported language version and this could lead to changes
like you are seeing. If that bit of code has a conditional compilation that
adds those members or deletes those other members based on the compiler's
language version then you could see that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2024-03-20 19:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20  5:57 [Bug default/31513] New: " quic_ashudas at quicinc dot com
2024-03-20 10:22 ` [Bug default/31513] " dodji at redhat dot com
2024-03-20 10:53 ` quic_ashudas at quicinc dot com
2024-03-20 10:54 ` quic_ashudas at quicinc dot com
2024-03-20 10:54 ` quic_ashudas at quicinc dot com
2024-03-21 10:19   ` Dodji Seketeli
2024-03-20 19:14 ` woodard at redhat dot com [this message]
2024-03-21  6:51 ` quic_ashudas at quicinc dot com
2024-03-21 10:19 ` dodji at seketeli dot org
2024-03-22  6:36 ` quic_ashudas at quicinc dot com
2024-03-22  6:36 ` quic_ashudas at quicinc dot com
2024-03-22  9:20 ` dodji at redhat dot com
2024-03-22  9:20 ` dodji at redhat dot com
2024-03-28 16:41 ` [Bug default/31513] abidiff wrongly considers data members moved to base class as harmful dodji at seketeli dot org
2024-03-29 17:40 ` dodji at seketeli dot org
2024-04-01 14:28 ` quic_ashudas at quicinc dot com
2024-04-02  9:54 ` dodji at seketeli dot org
2024-04-02 13:16 ` quic_jiafan at quicinc dot com
2024-04-03  9:58   ` Dodji Seketeli
2024-04-03  9:58 ` dodji at seketeli dot org
2024-04-03 10:22 ` quic_jiafan at quicinc dot com
2024-04-03 16:26 ` dodji at seketeli dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31513-9487-y7HZPD3aok@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).