From: "dodji at seketeli dot org" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/31513] abidiff wrongly considers data members moved to base class as harmful
Date: Fri, 29 Mar 2024 17:40:33 +0000 [thread overview]
Message-ID: <bug-31513-9487-lyIQiqbnGK@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31513-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=31513
--- Comment #11 from Dodji Seketeli <dodji at seketeli dot org> ---
Hello,
I have posted a candidate patch for this issue in commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=338394f5454990c715b52bb4bc2ed47b39d6528b.
You can get it from the Git repository of the project in the branch
"users/dodji/fixes" that can be browsed at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/users/dodji/fixes.
You can check it out with the command: git clone -b users/dodji/fixes
git://sourceware.org/git/libabigail.git. You can build the source code by
following the instructions at
https://sourceware.org/git/?p=libabigail.git;a=blob;f=COMPILING.
Please note that running abidiff on the two binaries that you provided shows
that several functions (instantiations of libstdc++ function templates) were
removed from the first binary. That is why abidiff sets the bit
ABIDIFF_ABI_INCOMPATIBLE_CHANGE in the exit value.
To suppress the noise coming from these libstdc++ function template
instantiations (which could be avoided by using the symbol visibility options
of g++, by the way), I provided a suppression file in the non-regression tests
accompanying the patch at
https://sourceware.org/git/?p=libabigail.git;a=blob;f=tests/data/test-abidiff-exit/PR31513/reported/libstdcpp.suppr;h=6c3761006a7c304c8a98dfd2a74097ef9e3282e2;hb=338394f5454990c715b52bb4bc2ed47b39d6528b.
You might want to test this branch on your system and tell me if that fixes the
issue for you. I hope this helps.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2024-03-29 17:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 5:57 [Bug default/31513] New: abidiff differences due to change in compiler version quic_ashudas at quicinc dot com
2024-03-20 10:22 ` [Bug default/31513] " dodji at redhat dot com
2024-03-20 10:53 ` quic_ashudas at quicinc dot com
2024-03-20 10:54 ` quic_ashudas at quicinc dot com
2024-03-20 10:54 ` quic_ashudas at quicinc dot com
2024-03-21 10:19 ` Dodji Seketeli
2024-03-20 19:14 ` woodard at redhat dot com
2024-03-21 6:51 ` quic_ashudas at quicinc dot com
2024-03-21 10:19 ` dodji at seketeli dot org
2024-03-22 6:36 ` quic_ashudas at quicinc dot com
2024-03-22 6:36 ` quic_ashudas at quicinc dot com
2024-03-22 9:20 ` dodji at redhat dot com
2024-03-22 9:20 ` dodji at redhat dot com
2024-03-28 16:41 ` [Bug default/31513] abidiff wrongly considers data members moved to base class as harmful dodji at seketeli dot org
2024-03-29 17:40 ` dodji at seketeli dot org [this message]
2024-04-01 14:28 ` quic_ashudas at quicinc dot com
2024-04-02 9:54 ` dodji at seketeli dot org
2024-04-02 13:16 ` quic_jiafan at quicinc dot com
2024-04-03 9:58 ` Dodji Seketeli
2024-04-03 9:58 ` dodji at seketeli dot org
2024-04-03 10:22 ` quic_jiafan at quicinc dot com
2024-04-03 16:26 ` dodji at seketeli dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-31513-9487-lyIQiqbnGK@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).