public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "sam at gentoo dot org" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/31642] New: ABI break for tree-sitter not reported as a breaking change by abidiff
Date: Mon, 15 Apr 2024 02:16:16 +0000	[thread overview]
Message-ID: <bug-31642-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=31642

            Bug ID: 31642
           Summary: ABI break for tree-sitter not reported as a breaking
                    change by abidiff
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: unassigned at sourceware dot org
          Reporter: sam at gentoo dot org
                CC: arsen at sourceware dot org, libabigail at sourceware dot org
  Target Milestone: ---

Recently, tree-sitter seems to have broken ABI between 0.22.2 and 0.22.4 but
libabigail didn't flag any breaking changes.

```
$ abidiff
/var/tmp/portage/dev-libs/tree-sitter-0.22.{2,4}/image/usr/lib64/libtree-sitter.so.0.22
--fail-no-debug-info --debug-info-dir1
/var/tmp/portage/dev-libs/tree-sitter-0.22.2/image/usr/lib/debug
--debug-info-dir2
/var/tmp/portage/dev-libs/tree-sitter-0.22.4/image/usr/lib/debug
Functions changes summary: 0 Removed, 4 Changed (45 filtered out), 0 Added
functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

4 functions with some indirect sub-type change:

  [C] 'function const size_t* ts_parser_cancellation_flag(const TSParser*)' at
parser.c:1921:1 has some indirect sub-type changes:
    parameter 1 of type 'const TSParser*' has sub-type changes:
      in pointed to type 'const TSParser':
        in unqualified underlying type 'typedef TSParser' at api.h:45:1:
          underlying type 'struct TSParser' at parser.c:90:1 changed:
            type size hasn't changed
            1 data member insertion:
              'bool has_scanner_error', at offset 11616 (in bits) at
parser.c:113:1

  [C] 'function void ts_query_cursor_delete(TSQueryCursor*)' at query.c:2986:1
has some indirect sub-type changes:
    parameter 1 of type 'TSQueryCursor*' has sub-type changes:
      in pointed to type 'typedef TSQueryCursor' at api.h:48:1:
        underlying type 'struct TSQueryCursor' at query.c:301:1 changed:
          type size changed from 1152 to 1216 (in bits)
          15 data member changes:
            type of 'TSTreeCursor cursor' changed:
              underlying type 'struct TSTreeCursor' at api.h:105:1 changed:
                type size changed from 192 to 256 (in bits)
                1 data member change:
                  type of 'uint32_t context[2]' changed:
                    type name changed from 'uint32_t[2]' to 'uint32_t[3]'
                    array type size changed from 64 to 96
                    array type subrange 1 changed length from 2 to 3
            'struct {QueryState* contents; uint32_t size; uint32_t capacity;}
states' offset changed from 256 to 320 (in bits) (by +64 bits)
            'struct {QueryState* contents; uint32_t size; uint32_t capacity;}
finished_states' offset changed from 384 to 448 (in bits) (by +64 bits)
            'CaptureListPool capture_list_pool' offset changed from 512 to 576
(in bits) (by +64 bits)
            'uint32_t depth' offset changed from 832 to 896 (in bits) (by +64
bits)
            'uint32_t max_start_depth' offset changed from 864 to 928 (in bits)
(by +64 bits)
            'uint32_t start_byte' offset changed from 896 to 960 (in bits) (by
+64 bits)
            'uint32_t end_byte' offset changed from 928 to 992 (in bits) (by
+64 bits)
            'TSPoint start_point' offset changed from 960 to 1024 (in bits) (by
+64 bits)
            'TSPoint end_point' offset changed from 1024 to 1088 (in bits) (by
+64 bits)
            'uint32_t next_state_id' offset changed from 1088 to 1152 (in bits)
(by +64 bits)
            'bool on_visible_node' offset changed from 1120 to 1184 (in bits)
(by +64 bits)
            'bool ascending' offset changed from 1128 to 1192 (in bits) (by +64
bits)
            'bool halted' offset changed from 1136 to 1200 (in bits) (by +64
bits)
            'bool did_exceed_match_limit' offset changed from 1144 to 1208 (in
bits) (by +64 bits)

  [C] 'function TSTreeCursor ts_tree_cursor_copy(const TSTreeCursor*)' at
tree_cursor.c:695:1 has some indirect sub-type changes:

  [C] 'function TSTreeCursor ts_tree_cursor_new(TSNode)' at tree_cursor.c:153:1
has some indirect sub-type changes:
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2024-04-15  2:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15  2:16 sam at gentoo dot org [this message]
2024-04-15  2:17 ` [Bug default/31642] " sam at gentoo dot org
2024-04-15  2:21 ` sam at gentoo dot org
2024-04-16  0:56 ` sam at gentoo dot org
2024-04-16  0:57 ` sam at gentoo dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31642-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).