[Bug default/31642] New: ABI break for tree-sitter not reported as a breaking change by abidiff

[Bug default/31642] New: ABI break for tree-sitter not reported as a breaking change by abidiff

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31642

            Bug ID: 31642
           Summary: ABI break for tree-sitter not reported as a breaking
                    change by abidiff
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: unassigned at sourceware dot org
          Reporter: sam at gentoo dot org
                CC: arsen at sourceware dot org, libabigail at sourceware dot org
  Target Milestone: ---

Recently, tree-sitter seems to have broken ABI between 0.22.2 and 0.22.4 but
libabigail didn't flag any breaking changes.

```
$ abidiff
/var/tmp/portage/dev-libs/tree-sitter-0.22.{2,4}/image/usr/lib64/libtree-sitter.so.0.22
--fail-no-debug-info --debug-info-dir1
/var/tmp/portage/dev-libs/tree-sitter-0.22.2/image/usr/lib/debug
--debug-info-dir2
/var/tmp/portage/dev-libs/tree-sitter-0.22.4/image/usr/lib/debug
Functions changes summary: 0 Removed, 4 Changed (45 filtered out), 0 Added
functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

4 functions with some indirect sub-type change:

  [C] 'function const size_t* ts_parser_cancellation_flag(const TSParser*)' at
parser.c:1921:1 has some indirect sub-type changes:
    parameter 1 of type 'const TSParser*' has sub-type changes:
      in pointed to type 'const TSParser':
        in unqualified underlying type 'typedef TSParser' at api.h:45:1:
          underlying type 'struct TSParser' at parser.c:90:1 changed:
            type size hasn't changed
            1 data member insertion:
              'bool has_scanner_error', at offset 11616 (in bits) at
parser.c:113:1

  [C] 'function void ts_query_cursor_delete(TSQueryCursor*)' at query.c:2986:1
has some indirect sub-type changes:
    parameter 1 of type 'TSQueryCursor*' has sub-type changes:
      in pointed to type 'typedef TSQueryCursor' at api.h:48:1:
        underlying type 'struct TSQueryCursor' at query.c:301:1 changed:
          type size changed from 1152 to 1216 (in bits)
          15 data member changes:
            type of 'TSTreeCursor cursor' changed:
              underlying type 'struct TSTreeCursor' at api.h:105:1 changed:
                type size changed from 192 to 256 (in bits)
                1 data member change:
                  type of 'uint32_t context[2]' changed:
                    type name changed from 'uint32_t[2]' to 'uint32_t[3]'
                    array type size changed from 64 to 96
                    array type subrange 1 changed length from 2 to 3
            'struct {QueryState* contents; uint32_t size; uint32_t capacity;}
states' offset changed from 256 to 320 (in bits) (by +64 bits)
            'struct {QueryState* contents; uint32_t size; uint32_t capacity;}
finished_states' offset changed from 384 to 448 (in bits) (by +64 bits)
            'CaptureListPool capture_list_pool' offset changed from 512 to 576
(in bits) (by +64 bits)
            'uint32_t depth' offset changed from 832 to 896 (in bits) (by +64
bits)
            'uint32_t max_start_depth' offset changed from 864 to 928 (in bits)
(by +64 bits)
            'uint32_t start_byte' offset changed from 896 to 960 (in bits) (by
+64 bits)
            'uint32_t end_byte' offset changed from 928 to 992 (in bits) (by
+64 bits)
            'TSPoint start_point' offset changed from 960 to 1024 (in bits) (by
+64 bits)
            'TSPoint end_point' offset changed from 1024 to 1088 (in bits) (by
+64 bits)
            'uint32_t next_state_id' offset changed from 1088 to 1152 (in bits)
(by +64 bits)
            'bool on_visible_node' offset changed from 1120 to 1184 (in bits)
(by +64 bits)
            'bool ascending' offset changed from 1128 to 1192 (in bits) (by +64
bits)
            'bool halted' offset changed from 1136 to 1200 (in bits) (by +64
bits)
            'bool did_exceed_match_limit' offset changed from 1144 to 1208 (in
bits) (by +64 bits)

  [C] 'function TSTreeCursor ts_tree_cursor_copy(const TSTreeCursor*)' at
tree_cursor.c:695:1 has some indirect sub-type changes:

  [C] 'function TSTreeCursor ts_tree_cursor_new(TSNode)' at tree_cursor.c:153:1
has some indirect sub-type changes:
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31642] ABI break for tree-sitter not reported as a breaking change by abidiff

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31642

--- Comment #1 from Sam James <sam at gentoo dot org> ---
Tarball of both builddirs is at
https://dev.gentoo.org/~sam/bugs/sourceware/31642/dev-libs-tree-sitter.tar.xz.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31642] ABI break for tree-sitter not reported as a breaking change by abidiff

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31642

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.gentoo.org/sho
                   |                            |w_bug.cgi?id=930039

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31642] ABI break for tree-sitter not reported as a breaking change by abidiff

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31642

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://github.com/tree-sit
                   |                            |ter/tree-sitter/issues/3296

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/31642] ABI break for tree-sitter not reported as a breaking change by abidiff

[sam at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31642

--- Comment #2 from Sam James <sam at gentoo dot org> ---
Forgot to say before:
```
$ abidiff --version
abidiff: 2.4.0
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.