public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: libabigail@sourceware.org
Subject: Re: Buildbot failure in Wildebeest Builder on whole buildset
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <cbdb0350628fa081dbbdfd8ac6807a5f04761f34.camel@klomp.org> (raw)
In-Reply-To: <20190117100851.0E597800729@builder.wildebeest.org>

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

On Thu, 2019-01-17 at 10:08 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building libabigail.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/5/builds/199

The problem is that DW_LANG_Rust and DW_LANG_C_plus_plus_03 were only
introduced with elfutils 0.170. The Debian builders have 0.168.

Simplest solution would probably be to define them in abg-dwarf-
reader.cc if undefined. See attached patch.

Cheers,

Mark

[-- Attachment #2: 0001-Define-DW_LANG_C_plus_plus_02-and-DW_LANG_Rust-when-.patch --]
[-- Type: text/x-patch, Size: 1029 bytes --]

From 318b4ed5a9e212f173b8c4308f89891ae8e86a3e Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Thu, 17 Jan 2019 11:19:02 +0100
Subject: [PATCH] Define DW_LANG_C_plus_plus_02 and DW_LANG_Rust when unknown.

Older elfutils (pre-0.170) don't define these constants in dwarf.h.

	* src/abg-dwarf-reader.cc: Define DW_LANG_C_plus_plus_03
	and DW_LANG_Rust when undefined.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 src/abg-dwarf-reader.cc | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index c9cffc3..aed79f1 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -66,6 +66,15 @@ ABG_END_EXPORT_DECLARATIONS
 #define UINT64_MAX 0xffffffffffffffff
 #endif
 
+/* Older elfutils dwarf.h might not define these language constants.  */
+#ifndef DW_LANG_C_plus_plus_03
+#define DW_LANG_C_plus_plus_03 0x0019
+#endif
+
+#ifndef DW_LANG_Rust
+#define DW_LANG_Rust 0x001c
+#endif
+
 using std::string;
 
 namespace abigail
-- 
1.8.3.1


  reply	other threads:[~2019-01-17 10:21 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard [this message]
2019-01-01  0:00   ` Dodji Seketeli
2019-01-01  0:00     ` Mark Wielaard
2019-01-01  0:00       ` Dodji Seketeli
2019-01-01  0:00     ` Mark Wielaard
2019-01-01  0:00       ` Dodji Seketeli
  -- strict thread matches above, loose matches on Subject: below --
2022-01-17 13:19 buildbot
2021-12-21 19:18 buildbot
2021-12-14 15:55 buildbot
2021-12-15 13:01 ` Mark Wielaard
2021-11-29  8:05 buildbot
2021-11-29 11:23 ` Mark Wielaard
2021-10-27 11:11 buildbot
2021-10-27 11:14 ` Mark Wielaard
2021-10-27 12:04   ` Dodji Seketeli
2021-10-18 10:58 buildbot
2021-09-23 12:12 buildbot
2021-09-23 12:19 ` Mark Wielaard
2021-08-11 17:08 buildbot
2021-07-16 10:11 buildbot
2021-07-16 10:33 ` Mark Wielaard
2021-04-12 15:48 buildbot
2021-03-18 16:05 buildbot
2021-03-19 23:03 ` Mark Wielaard
2020-12-02 15:32 buildbot
2020-11-27 16:59 buildbot
2020-11-25 12:52 buildbot
2020-11-25  8:51 buildbot
2020-11-12 10:50 buildbot
2020-11-02 17:21 buildbot
2020-10-27  9:47 buildbot
2020-10-27 11:30 ` Mark Wielaard
2020-10-27 13:12   ` Mark Wielaard
2020-10-28  9:30     ` Dodji Seketeli
2020-10-28 10:12       ` Mark Wielaard
2020-10-14 10:31 buildbot
2020-10-09  9:35 buildbot
2020-07-30 15:29 buildbot
2020-07-30 15:38 ` Mark Wielaard
2020-07-28 14:40 buildbot
2020-07-28 14:41 ` Mark Wielaard
2020-05-04  9:36 buildbot
2020-04-23 13:09 buildbot
2020-04-23 13:32 ` Mark Wielaard
2020-03-26 15:47 buildbot
2020-03-19 10:55 buildbot
2020-03-19 12:25 ` Mark Wielaard
2020-03-20 22:23   ` Dodji Seketeli
2020-03-12 13:41 buildbot
2020-01-01  0:00 buildbot
2020-01-01  0:00 buildbot
2020-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Matthias Maennich via libabigail
2019-01-01  0:00   ` Mark Wielaard
2019-01-01  0:00     ` Matthias Maennich via libabigail
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00   ` Dodji Seketeli
2019-01-01  0:00     ` Mark Wielaard
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 buildbot
2019-01-01  0:00 ` Mark Wielaard
2019-01-01  0:00   ` Dodji Seketeli
2019-01-01  0:00 buildbot
2018-01-01  0:00 buildbot
2018-01-01  0:00 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbdb0350628fa081dbbdfd8ac6807a5f04761f34.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).