Re: Buildbot failure in Wildebeest Builder on whole buildset

[Mark Wielaard <mark@klomp.org>]

On Fri, 2019-09-27 at 13:30 +0000, buildbot@builder.wildebeest.org
wrote:
> The Buildbot has detected a failed build on builder whole buildset
> while building libabigail.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/9/builds/287
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-s390x
> 
> Build Reason: <unknown>
> Blamelist: Dodji Seketeli <dodji@redhat.com>
> 
> BUILD FAILED: failed test (failure)
> 
> Sincerely,
>  -The BuildbotThe Buildbot has detected a failed build on builder
> whole buildset while building libabigail.
> Full details are available at:
>     https://builder.wildebeest.org/buildbot/#builders/14/builds/268
> 
> Buildbot URL: https://builder.wildebeest.org/buildbot/
> 
> Worker for this Build: fedora-ppc64

The ppc64[be] worker was offline for a while. Which is why the issue
was only reported today. But it has already been fixed. We already saw
the s390x worker fail (also big endian) and Dodji fixed it with:

commit 4fba6bea177ffa1981b8252f7f1967814b3ecf94
Author: Dodji Seketeli <dodji@redhat.com>
Date:   Mon Sep 23 15:55:08 2019 +0200

    Fix reading of relocation sections when endianness mismatches
    
    When the endianness of the ELF binary differs from the endianness of
    the host, some byte swapping needs to happen when we read the reloc
    section to either determine the format of the kernel symbol table or
    to get the set of symbols referenced by the kernel symbol table.
    
    So we need to use elf_getdata rather than elf_rawdata to read the data
    from the reloc section, because the former handles the proper byte
    swapping for us.
    
    This patch does just that and thus fixes the build breakage that is
    occuring when running the testreaddwarf test on s390x (big endian),
    especially when trying to read the AARCH64 little endian binary
    data/test-read-dwarf/PR25007-sdhci.ko.
    
            * src/abg-dwarf-reader.cc
            (read_context::{get_ksymtab_format_module,
            populate_symbol_map_from_ksymtab_reloc}): Use elf_getdata rather
            than elf_rawdata.
    
    Signed-off-by: Dodji Seketeli <dodji@redhat.com>

All green again:
https://builder.wildebeest.org/buildbot/#/builders?tags=libabigail

Cheers,

Mark