From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Joe Simmons-Talbott <josimmon@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] fxprintf: Get rid of alloca
Date: Wed, 6 Sep 2023 13:56:40 -0300 [thread overview]
Message-ID: <04402456-1e27-835a-8c39-d1d0388da65c@linaro.org> (raw)
In-Reply-To: <20230810133344.GH3849957@oak>
On 10/08/23 10:34, Joe Simmons-Talbott wrote:
> On Wed, Jul 19, 2023 at 03:12:43PM -0300, Adhemerval Zanella Netto wrote:
>>
>>
>> On 07/07/23 14:53, Joe Simmons-Talbott via Libc-alpha wrote:
>>> Use a scratch_buffer rather than alloca/malloc to avoid potential stack
>>> overflow.
>>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> Should I apply this despite the seemingly unrelated test timeout[1] in
> CI?
>
> [1]
> https://patchwork.sourceware.org/project/glibc/patch/20230707175349.2096131-1-josimmon@redhat.com/
Yes, I think this failure is transient.
prev parent reply other threads:[~2023-09-06 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 17:53 Joe Simmons-Talbott
2023-07-19 18:12 ` Adhemerval Zanella Netto
2023-08-10 13:34 ` Joe Simmons-Talbott
2023-09-06 16:56 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04402456-1e27-835a-8c39-d1d0388da65c@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).