From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] i386: Support CFLAGS which imply -fno-omit-frame-pointer [BZ #20729]
Date: Fri, 28 Oct 2016 15:08:00 -0000 [thread overview]
Message-ID: <044f7bf1-4aa6-ba2d-db81-d93459bf06ab@redhat.com> (raw)
In-Reply-To: <20161028150542.A781D439942E0@oldenburg.str.redhat.com>
On 10/28/2016 11:05 AM, Florian Weimer wrote:
> 2016-10-28 Florian Weimer <fweimer@redhat.com>
>
> [BZ #20729]
> Support i386 builds with CFLAGS which imply -fno-omit-frame-pointer.
> * sysdeps/unix/sysv/linux/i386/Makefile
> (uses-6-syscall-arguments): Define.
> [subdir == misc] (CFLAGS-epoll_pwait.o, CFLAGS-epoll_pwait.os)
> (CFLAGS-mmap.o, CFLAGS-mmap.os, CFLAGS-mmap64.o, CFLAGS-mmap64.os)
> (CFLAGS-pselect.o, CFLAGS-pselect.os, CFLAGS-rtld-mmap.os): Use it.
> [subdir = sysvipc] (CFLAGS-semtimedop.o, CFLAGS-semtimedop.os):
> Likewise.
> [subdir = io] (CFLAGS-posix_fadvise64.o, CFLAGS-posix_fadvise64.os)
> (CFLAGS-posix_fallocate.o, CFLAGS-posix_fallocate.os)
> (CFLAGS-posix_fallocate64.o, CFLAGS-posix_fallocate64.os)
> (CFLAGS-sync_file_range.o, CFLAGS-sync_file_range.os)
> (CFLAGS-fallocate.o, CFLAGS-fallocate.os, CFLAGS-fallocate64.o)
> (CFLAGS-fallocate64.os): Likewise.
> [subdir = nptl] (CFLAGS-pthread_rwlock_timedrdlock.o)
> (CFLAGS-pthread_rwlock_timedrdlock.os)
> (CFLAGS-pthread_rwlock_timedwrlock.o)
> (CFLAGS-pthread_rwlock_timedwrlock.os, CFLAGS-sem_wait.o)
> (CFLAGS-sem_wait.os, CFLAGS-sem_timedwait.o)
> (CFLAGS-sem_timedwait.os): Likewise.
I like 'uses-6-syscall-arguments' to make this more readable.
LGTM.
Tested on i486 build.
--
Cheers,
Carlos.
prev parent reply other threads:[~2016-10-28 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 15:05 Florian Weimer
2016-10-28 15:08 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=044f7bf1-4aa6-ba2d-db81-d93459bf06ab@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).