Re: [PATCH v11 1/4] elf: Add la_activity during application exit

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 25/01/2022 00:06, Adhemerval Zanella wrote:
> 
> 
> On 24/01/2022 18:47, Carlos O'Donell wrote:
>> On 1/24/22 08:46, Adhemerval Zanella wrote:
>>> la_activity is not called during application exit, even though
>>> la_objclose is.
>>
>> This fails on my x86_64 tester.
>>
>> tst-audit23.c:150: numeric comparison failure
>>    left: 140392013825880 (0x7faf901d0758); from: cookie
>>   right: 18446744073709551615 (0xffffffffffffffff); from: last_act_cookie
>> tst-audit23.c:150: numeric comparison failure
>>    left: 140392013825880 (0x7faf901d0758); from: cookie
>>   right: 18446744073709551615 (0xffffffffffffffff); from: last_act_cookie
>> tst-audit23.c:150: numeric comparison failure
>>    left: 93825010503032 (0x5555566c0d78); from: cookie
>>   right: 18446744073709551615 (0xffffffffffffffff); from: last_act_cookie
>> tst-audit23.c:145: numeric comparison failure
>>    left: 2 (0x2); from: acts[nacts]
>>   right: 140392013825880 (0x7faf901d0758); from: cookie
>> tst-audit23.c:214: numeric comparison failure
>>    left: 2 (0x2); from: last_act_cookie
>>   right: 140392013825880 (0x7faf901d0758); from: cookie
>> tst-audit23.c:132: numeric comparison failure
>>    left: 2 (0x2); from: last_act
>>   right: 0 (0x0); from: LA_ACT_CONSISTENT
>> tst-audit23.c:150: numeric comparison failure
>>    left: 140392013825880 (0x7faf901d0758); from: cookie
>>   right: 2 (0x2); from: last_act_cookie
>> error: 7 test failures
>>
>> Reproduces with:
>> make test t=elf/tst-audit23
>>
>> Tester is using: "--enable-hardcoded-path-in-tests" to exercise slightly
>> different testing paths.
> 
> I really can't reproduce it neither on x86_64 nor on i686 with both 
> gcc 11 and 12.  And the buildbot also did not trigger any failure.
> I checked with both with and without --enable-hardcoded-path-in-tests,
> and also on aarch64 and powerpc64le.
> 
> So maybe is it something in your environment?

It is a failure on the test in fact, the patch below fixed it:

diff --git a/elf/tst-audit23.c b/elf/tst-audit23.c
index c6393a31ff..abc35791a5 100644
--- a/elf/tst-audit23.c
+++ b/elf/tst-audit23.c
@@ -131,7 +131,7 @@ do_test (int argc, char *argv[])
          if (cookie != last_act_cookie && last_act_cookie != -1)
            TEST_COMPARE (last_act, LA_ACT_CONSISTENT);
 
-         if (this_act == LA_ACT_ADD && acts[nacts - 1] != cookie)
+         if (this_act == LA_ACT_ADD && acts[nacts] != cookie)
            {
              acts[nacts++] = cookie;
              last_act_cookie = cookie;