public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Kito Cheng <kito.cheng@sifive.com>
Cc: Palmer Dabbelt <palmer@rivosinc.com>,
	libc-alpha@sourceware.org,  joseph@codesourcery.com,
	jeffreyalaw@gmail.com, Darius Rad <darius@bluespec.com>,
	 christoph.muellner@vrull.eu, DJ Delorie <dj@redhat.com>,
	Andrew Waterman <andrew@sifive.com>,
	Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: Re: [PATCH] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1
Date: Thu, 09 Mar 2023 23:18:25 +0800	[thread overview]
Message-ID: <0c9b0538369a8632834a7bb9b3e9855c61fbe281.camel@xry111.site> (raw)
In-Reply-To: <CALLt3TgMvf0-mNXA0tx-cv3yHuKuZ0BcwzqeV9m6Nd-knGV1Zg@mail.gmail.com>

On Thu, 2023-03-09 at 22:59 +0800, Kito Cheng wrote:
> Hi Ruoyao:
> 
> GCC isn't set that to -1, but clang/LLVM did, see
> https://github.com/llvm/llvm-project/issues/60781 and
> https://reviews.llvm.org/D121122

Hmm, it turns -ffast-math into "-fslow-math" :(.

> Seems like LLVM folks are consider to rever that, but even clang/LLVM
> revert that,
> 
> the issue still there: should we treat indeterminable precision as
> evaluating value as long double?
> 
> It's almost no benefit for those targets who have 128 bit long double
> type.

I agree that if __FLT_EVAL_METHOD__ is not 0, 1, or 2, and the target
does not have native support for some "special" floating point types, we
*should* make float_t float and double_t double.

But doing so may blow up rolling-release distros: if a library uses
float_t and double_t in the API and the distro maintainers rebuilt the
library with a new Glibc, but (s)he has not rebuilt an application using
the library yet, the application will just crash or produce "strange"
results.  Maybe we'll need to issue an alert about this to the distro
maintainers.

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2023-03-09 15:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17  2:26 Kito Cheng
2023-02-18 18:29 ` Palmer Dabbelt
2023-03-09 14:14   ` Kito Cheng
2023-03-09 14:33     ` Xi Ruoyao
2023-03-09 14:59       ` Kito Cheng
2023-03-09 15:18         ` Xi Ruoyao [this message]
2023-03-09 16:03           ` Kito Cheng
2023-03-09 16:20           ` Wilco Dijkstra
2023-03-09 19:37     ` Wilco Dijkstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c9b0538369a8632834a7bb9b3e9855c61fbe281.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=andrew@sifive.com \
    --cc=christoph.muellner@vrull.eu \
    --cc=darius@bluespec.com \
    --cc=dj@redhat.com \
    --cc=jeffreyalaw@gmail.com \
    --cc=joseph@codesourcery.com \
    --cc=kito.cheng@sifive.com \
    --cc=libc-alpha@sourceware.org \
    --cc=palmer@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).