From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Kito Cheng <kito.cheng@sifive.com>, Palmer Dabbelt <palmer@rivosinc.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"joseph@codesourcery.com" <joseph@codesourcery.com>,
"jeffreyalaw@gmail.com" <jeffreyalaw@gmail.com>,
Darius Rad <darius@bluespec.com>,
"christoph.muellner@vrull.eu" <christoph.muellner@vrull.eu>,
DJ Delorie <dj@redhat.com>, Andrew Waterman <andrew@sifive.com>
Subject: Re: [PATCH] Remap __GLIBC_FLT_EVAL_METHOD to 0 if __FLT_EVAL_METHOD__ is -1
Date: Thu, 9 Mar 2023 19:37:57 +0000 [thread overview]
Message-ID: <PAWPR08MB8982BED9F50941CB843A84C783B59@PAWPR08MB8982.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CALLt3Tj51VjoOC5GzJT0mrRDqsAQmtwXN3qJANoNGEjHq5qEyg@mail.gmail.com>
Hi Kito,
This comment reads a bit strange after the change:
> > /* In the default version of this header, follow __FLT_EVAL_METHOD__.
> > - -1 is mapped to 2 (considering evaluation as long double to be a
> > + -1 is mapped to 0 (considering evaluation as same precision to be a
> > conservatively safe assumption), and if __FLT_EVAL_METHOD__ is not
> > defined then assume there is no excess precision and use the value
> > 0. */
Maybe this would be clearer?
In the default version of this header, follow __FLT_EVAL_METHOD__.
If __FLT_EVAL_METHOD__ is not defined or set to -1, assume there is no
excess precision and use the value 0 (this is correct for most targets).
Also separating the commit message from the rest of the discussion would be
good - I assume the quote from the C99 standard is not part of it?
Cheers,
Wilco
prev parent reply other threads:[~2023-03-09 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 2:26 Kito Cheng
2023-02-18 18:29 ` Palmer Dabbelt
2023-03-09 14:14 ` Kito Cheng
2023-03-09 14:33 ` Xi Ruoyao
2023-03-09 14:59 ` Kito Cheng
2023-03-09 15:18 ` Xi Ruoyao
2023-03-09 16:03 ` Kito Cheng
2023-03-09 16:20 ` Wilco Dijkstra
2023-03-09 19:37 ` Wilco Dijkstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAWPR08MB8982BED9F50941CB843A84C783B59@PAWPR08MB8982.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=darius@bluespec.com \
--cc=dj@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=joseph@codesourcery.com \
--cc=kito.cheng@sifive.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).