* [PATCH] Fix elf/tst-audit25a with default bind now toolchains
@ 2022-02-02 14:08 Szabolcs Nagy
2022-02-02 14:20 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Szabolcs Nagy @ 2022-02-02 14:08 UTC (permalink / raw)
To: libc-alpha
This test relies on lazy binding for the executable so request that
explicitly in case the toolchain defaults to bind now.
---
elf/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/elf/Makefile b/elf/Makefile
index e380b26d8a..5bdf0a383d 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -2227,6 +2227,7 @@ $(objpfx)tst-audit25a: $(objpfx)tst-audit25mod1.so \
$(objpfx)tst-audit25mod2.so \
$(objpfx)tst-audit25mod3.so \
$(objpfx)tst-audit25mod4.so
+LDFLAGS-tst-audit25a = -Wl,-z,lazy
$(objpfx)tst-audit25mod1.so: $(objpfx)tst-audit25mod3.so
LDFLAGS-tst-audit25mod1.so = -Wl,-z,now
$(objpfx)tst-audit25mod2.so: $(objpfx)tst-audit25mod4.so
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix elf/tst-audit25a with default bind now toolchains
2022-02-02 14:08 [PATCH] Fix elf/tst-audit25a with default bind now toolchains Szabolcs Nagy
@ 2022-02-02 14:20 ` Florian Weimer
2022-02-02 15:09 ` Carlos O'Donell
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2022-02-02 14:20 UTC (permalink / raw)
To: Szabolcs Nagy via Libc-alpha; +Cc: Szabolcs Nagy, Carlos O'Donell
* Szabolcs Nagy via Libc-alpha:
> This test relies on lazy binding for the executable so request that
> explicitly in case the toolchain defaults to bind now.
> ---
> elf/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index e380b26d8a..5bdf0a383d 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -2227,6 +2227,7 @@ $(objpfx)tst-audit25a: $(objpfx)tst-audit25mod1.so \
> $(objpfx)tst-audit25mod2.so \
> $(objpfx)tst-audit25mod3.so \
> $(objpfx)tst-audit25mod4.so
> +LDFLAGS-tst-audit25a = -Wl,-z,lazy
> $(objpfx)tst-audit25mod1.so: $(objpfx)tst-audit25mod3.so
> LDFLAGS-tst-audit25mod1.so = -Wl,-z,now
> $(objpfx)tst-audit25mod2.so: $(objpfx)tst-audit25mod4.so
Looks okay. Probably needs RM approval.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix elf/tst-audit25a with default bind now toolchains
2022-02-02 14:20 ` Florian Weimer
@ 2022-02-02 15:09 ` Carlos O'Donell
0 siblings, 0 replies; 3+ messages in thread
From: Carlos O'Donell @ 2022-02-02 15:09 UTC (permalink / raw)
To: Florian Weimer, Szabolcs Nagy via Libc-alpha; +Cc: Szabolcs Nagy
On 2/2/22 09:20, Florian Weimer wrote:
> * Szabolcs Nagy via Libc-alpha:
>
>> This test relies on lazy binding for the executable so request that
>> explicitly in case the toolchain defaults to bind now.
>> ---
>> elf/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/elf/Makefile b/elf/Makefile
>> index e380b26d8a..5bdf0a383d 100644
>> --- a/elf/Makefile
>> +++ b/elf/Makefile
>> @@ -2227,6 +2227,7 @@ $(objpfx)tst-audit25a: $(objpfx)tst-audit25mod1.so \
>> $(objpfx)tst-audit25mod2.so \
>> $(objpfx)tst-audit25mod3.so \
>> $(objpfx)tst-audit25mod4.so
>> +LDFLAGS-tst-audit25a = -Wl,-z,lazy
>> $(objpfx)tst-audit25mod1.so: $(objpfx)tst-audit25mod3.so
>> LDFLAGS-tst-audit25mod1.so = -Wl,-z,now
>> $(objpfx)tst-audit25mod2.so: $(objpfx)tst-audit25mod4.so
>
> Looks okay. Probably needs RM approval.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
ACK for 2.35. Please push.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-02 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 14:08 [PATCH] Fix elf/tst-audit25a with default bind now toolchains Szabolcs Nagy
2022-02-02 14:20 ` Florian Weimer
2022-02-02 15:09 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).