From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Carlos O'Donell <carlos@redhat.com>,
Adhemerval Zanella <azanella@sourceware.org>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [glibc] elf: Fix 64 time_t support for installed statically binaries
Date: Mon, 17 Jan 2022 10:08:36 -0300 [thread overview]
Message-ID: <0d4040d0-3e5f-0c92-b4c2-9944b9668b1f@linaro.org> (raw)
In-Reply-To: <d4c4ee98-9b38-bbff-70af-a01fc29654bd@redhat.com>
On 14/01/2022 18:57, Carlos O'Donell wrote:
> On 1/12/22 08:30, Adhemerval Zanella via Glibc-cvs wrote:
>> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0b8e83eb1455f3c0332eeb1f96fbc262fbd054e0
>>
>> commit 0b8e83eb1455f3c0332eeb1f96fbc262fbd054e0
>> Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>> Date: Wed Dec 29 10:20:46 2021 -0300
>>
>> elf: Fix 64 time_t support for installed statically binaries
>>
>> The usage of internal static symbol for statically linked binaries
>> does not work correctly for objects built with -D_TIME_BITS=64,
>> since the internal definition does not provide the expected aliases.
>>
>> This patch makes it to use the default stat functions instead (which
>> uses the default 64 time_t alias and types).
>>
>> Checked on i686-linux-gnu.
>
> Per the Monday patch queue review notes:
> https://sourceware.org/pipermail/libc-alpha/2022-January/135137.html
>
> I was just going to review this when I noticed that it looks like you pushed what appears
> to be 3 patches by accident, and then reverted 2 patches.
>
> You noted the accidental push here:
> https://sourceware.org/pipermail/libc-alpha/2022-January/135208.html
> Thank you!
>
> This patch was still pushed though.
>
> May I suggest you revert this for completeness and reapply with RB/TBs?
Sorry about that, I will revert and reapply.
prev parent reply other threads:[~2022-01-17 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220112133028.A84B6393D035@sourceware.org>
2022-01-14 21:57 ` Carlos O'Donell
2022-01-17 13:08 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d4040d0-3e5f-0c92-b4c2-9944b9668b1f@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=azanella@sourceware.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).