From: Paul Eggert <eggert@cs.ucla.edu>
To: Joseph Myers <joseph@codesourcery.com>,
Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: libc-alpha@sourceware.org, Noah Goldstein <goldstein.w.n@gmail.com>
Subject: Re: [PATCH] Fix all the misspellings -- BZ 25337
Date: Mon, 22 May 2023 16:11:28 -0700 [thread overview]
Message-ID: <11b4b375-c948-e2b3-5831-bb02c212df3b@cs.ucla.edu> (raw)
In-Reply-To: <fc6625b4-24d3-26f1-3084-2997360b78b@codesourcery.com>
On 5/22/23 14:24, Joseph Myers wrote:
> On Sun, 21 May 2023, Paul Pluzhnikov via Libc-alpha wrote:
>
>> timezone/africa | 2 +-
>> timezone/antarctica | 2 +-
>> timezone/asia | 2 +-
>> timezone/australasia | 6 +--
>> timezone/europe | 8 +--
>> timezone/southamerica | 4 +-
>
> Making local changes to these files (test inputs from an old upstream
> version of tzdata) is questionable. In general, check against
> https://sourceware.org/glibc/wiki/SharedSourceFiles and
> https://sourceware.org/glibc/wiki/Regeneration for files that are either
> taken verbatim from upstream sources or are generated files.
For what it's worth, those spelling errors were corrected upstream some
time ago. It might be simpler (for someone who knows how those test
cases work) to reimport the current tzdb release than to worry about
maintaining the old tzdata copy. In the meantime I'd leave those files
alone.
next prev parent reply other threads:[~2023-05-22 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 0:04 [RFC] Fix spelling errors? Paul Pluzhnikov
2023-05-15 5:07 ` Noah Goldstein
2023-05-21 21:23 ` [PATCH] Fix all the misspellings -- BZ 25337 Paul Pluzhnikov
2023-05-21 23:27 ` Noah Goldstein
2023-05-22 21:24 ` Joseph Myers
2023-05-22 23:11 ` Paul Eggert [this message]
2023-05-22 2:55 ` Paul Pluzhnikov
2023-05-22 3:22 ` Noah Goldstein
2023-05-22 3:47 ` [PATCH] Fix misspellings in sysdeps/x86_64/fpu/multiarch " Paul Pluzhnikov
2023-05-22 20:25 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11b4b375-c948-e2b3-5831-bb02c212df3b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=goldstein.w.n@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).