From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: GLIBC Devel <libc-alpha@sourceware.org>
Subject: Re: [RFC] Fix spelling errors?
Date: Mon, 15 May 2023 00:07:07 -0500 [thread overview]
Message-ID: <CAFUsyfKw4GJM7=KeknCh2cyPZFWx-t4z+m_0teWOyaPMHm7Mqw@mail.gmail.com> (raw)
In-Reply-To: <CALoOobPW9LT1Gv-2bQgjwmXDFhM+HxkzgHXO7GjGgftqWmh2Zw@mail.gmail.com>
On Sun, May 14, 2023 at 7:04 PM Paul Pluzhnikov via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Greetings,
>
> I just came across
> https://sourceware.org/bugzilla/show_bug.cgi?id=25337, which points to
> https://fossies.org/linux/test/glibc-master.d6c72f9.230511.tar.xz/codespell.html,
> which lists 111 instances of fucntion (among others).
>
> grep -r fucntion .
> ./sysdeps/x86_64/fpu/multiarch/svml_d_acosh4_core_avx2.S: /*
> Scalar math fucntion call
> ./sysdeps/x86_64/fpu/multiarch/svml_d_cosh4_core_avx2.S: /*
> Scalar math fucntion call
> ./sysdeps/x86_64/fpu/multiarch/svml_s_asinhf4_core_sse4.S: /*
> Scalar math fucntion call
> ./sysdeps/x86_64/fpu/multiarch/svml_d_erfc2_core_sse4.S: /*
> Scalar math fucntion call
> ./sysdeps/x86_64/fpu/multiarch/svml_s_log10f4_core_sse4.S: /*
> Scalar math fucntion call
> ... etc.
>
> 1. Should we fix this (I think yes)
Sure. Patch is welcome.
> 2. (If so) Can I just fix them, or do I need to go through the regular review?
Post a patch, I'll approve it.
> 3. Would it be better to fix them all in a single commit, or split
> across several (e.g. one misspelling at a time?)
>
One commit for something like this should be fine.
> Thanks!
> --
> Paul Pluzhnikov
next prev parent reply other threads:[~2023-05-15 5:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 0:04 Paul Pluzhnikov
2023-05-15 5:07 ` Noah Goldstein [this message]
2023-05-21 21:23 ` [PATCH] Fix all the misspellings -- BZ 25337 Paul Pluzhnikov
2023-05-21 23:27 ` Noah Goldstein
2023-05-22 21:24 ` Joseph Myers
2023-05-22 23:11 ` Paul Eggert
2023-05-22 2:55 ` Paul Pluzhnikov
2023-05-22 3:22 ` Noah Goldstein
2023-05-22 3:47 ` [PATCH] Fix misspellings in sysdeps/x86_64/fpu/multiarch " Paul Pluzhnikov
2023-05-22 20:25 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFUsyfKw4GJM7=KeknCh2cyPZFWx-t4z+m_0teWOyaPMHm7Mqw@mail.gmail.com' \
--to=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).