From: "Andreas K. Huettel" <dilfridge@gentoo.org>
To: libc-alpha@sourceware.org, glaubitz@physik.fu-berlin.de
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] m68: Enforce 4-byte alignment on internal locks (BZ #29537)
Date: Fri, 02 Sep 2022 19:29:03 +0200 [thread overview]
Message-ID: <12045544.O9o76ZdvQC@pinacolada> (raw)
In-Reply-To: <20220830133504.2669323-1-adhemerval.zanella@linaro.org>
Am Dienstag, 30. August 2022, 15:35:04 CEST schrieb Adhemerval Zanella via Libc-alpha:
> The HPPA also requires a 16-byte alignment for locks, although it is
> just a historical artifact to keep compatibility with old
> implementation.
> ---
> sysdeps/nptl/libc-lockP.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/nptl/libc-lockP.h b/sysdeps/nptl/libc-lockP.h
> index d3a6837fd2..9efe962588 100644
> --- a/sysdeps/nptl/libc-lockP.h
> +++ b/sysdeps/nptl/libc-lockP.h
> @@ -34,7 +34,7 @@
> #include <tls.h>
>
> /* Mutex type. */
> -typedef int __libc_lock_t;
> +typedef int __libc_lock_t __LOCK_ALIGNMENT;
> typedef struct { pthread_mutex_t mutex; } __rtld_lock_recursive_t;
> typedef pthread_rwlock_t __libc_rwlock_t;
>
>
I've added this to glibc-2.35, recompiled and reinstalled glibc, and was then
able to
* update my qemu-m68k chroot to newest packages
* and have it rebuild itself fully
at MAKEOPTS="-j17" without any issues.
(This means, whereas building python always failed before, now I built python-3.10
and python-3.11 each twice, without problems. The chroot contains the Gentoo
@system set, so glibc, binutils, gcc, ...)
So, LGTM and thank you!!!
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
prev parent reply other threads:[~2022-09-02 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 13:35 Adhemerval Zanella
2022-08-30 13:46 ` John Paul Adrian Glaubitz
2022-08-30 13:54 ` Adhemerval Zanella Netto
2022-08-30 14:18 ` Carlos O'Donell
2022-08-30 14:23 ` Adhemerval Zanella Netto
2022-08-30 16:32 ` Richard Henderson
2022-08-30 17:04 ` Adhemerval Zanella Netto
2022-09-02 17:29 ` Andreas K. Huettel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12045544.O9o76ZdvQC@pinacolada \
--to=dilfridge@gentoo.org \
--cc=adhemerval.zanella@linaro.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).