From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Stafford Horne <shorne@gmail.com>
Cc: Florian Weimer <fweimer@redhat.com>,
Openrisc <openrisc@lists.librecores.org>,
GLIBC patches <libc-alpha@sourceware.org>
Subject: Re: [OpenRISC] [PATCH v5 00/13] Glibc OpenRISC port
Date: Tue, 25 Jan 2022 14:07:32 -0300 [thread overview]
Message-ID: <121ae1cd-87c5-399f-8a1e-f9d2e4618be0@linaro.org> (raw)
In-Reply-To: <Ye9QLX3znGzPdDDF@antec>
On 24/01/2022 22:19, Stafford Horne wrote:
> On Mon, Jan 24, 2022 at 10:54:58AM -0300, Adhemerval Zanella wrote:
>>
>>
>> On 24/01/2022 10:23, Florian Weimer via Libc-alpha wrote:
>>> * Stafford Horne:
>>>
>>>> This is the OpenRISC port for glibc that I have been working on.
>>>
>>> The port does not define PI_STATIC_AND_HIDDEN. Is this really
>>> necessary, or just an oversight due to the way the port was constructed
>>> (presumably with MIPS as the template)?
>>>
>>> PI_STATIC_AND_HIDDEN means that references to static functions and data
>>> and symbols with hidden visibility do not need any run-time relocations
>>> after the final link, with the build flags used by glibc.
>>
>> At least the loader with a simple hello world does not fail with qemu with
>> PI_STATIC_AND_HIDDEN set.
>>
>> Staffork, could you confirm it is ok to make or1k use PI_STATIC_AND_HIDDEN?
>
> Yes, this was just an oversight and it didn't show up during testing. I think
> this is OK as described or1k does not need runtime relocations for hidden
> symbols after the final link.
>
> Shall I make the patch to add configure.ac? Or do you have that ready to go
> already?
I would tested briefly with qemu-system, I will send a patch so you can
review.
prev parent reply other threads:[~2022-01-25 17:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 3:14 Stafford Horne
2022-01-04 3:14 ` [PATCH v5 01/13] elf: Add reloc for OpenRISC Stafford Horne
2022-01-04 3:14 ` [PATCH v5 02/13] linux/syscalls: Add or1k_atomic syscall " Stafford Horne
2022-01-04 3:14 ` [PATCH v5 03/13] or1k: ABI Implementation Stafford Horne
2022-01-04 3:14 ` [PATCH v5 04/13] or1k: startup and dynamic linking code Stafford Horne
2022-01-04 3:14 ` [PATCH v5 05/13] or1k: Thread Local Storage support Stafford Horne
2022-01-04 3:14 ` [PATCH v5 06/13] or1k: Atomics and Locking primitives Stafford Horne
2022-01-04 3:14 ` [PATCH v5 07/13] or1k: math soft float support Stafford Horne
2022-01-04 3:14 ` [PATCH v5 08/13] or1k: Linux Syscall Interface Stafford Horne
2022-01-04 3:14 ` [PATCH v5 09/13] or1k: Linux ABI Stafford Horne
2022-01-04 3:14 ` [PATCH v5 10/13] or1k: ABI lists Stafford Horne
2022-01-04 12:27 ` Adhemerval Zanella
2022-01-04 21:37 ` Stafford Horne
2022-01-04 3:14 ` [PATCH v5 11/13] or1k: Build Infrastructure Stafford Horne
2022-01-04 3:14 ` [PATCH v5 12/13] build-many-glibcs.py: add OpenRISC support Stafford Horne
2022-01-04 3:14 ` [PATCH v5 13/13] Documentation for OpenRISC port Stafford Horne
2022-01-04 12:28 ` Adhemerval Zanella
2022-01-04 21:38 ` Stafford Horne
2022-01-04 12:34 ` [PATCH v5 00/13] Glibc " Adhemerval Zanella
2022-01-04 21:36 ` Stafford Horne
2022-01-05 21:34 ` [PATCH v5 00/13] Glibc OpenRISC port - PUSHED Stafford Horne
2022-01-24 13:23 ` [OpenRISC] [PATCH v5 00/13] Glibc OpenRISC port Florian Weimer
2022-01-24 13:54 ` Adhemerval Zanella
2022-01-25 1:19 ` Stafford Horne
2022-01-25 17:07 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121ae1cd-87c5-399f-8a1e-f9d2e4618be0@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).