public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
To: libc-alpha@sourceware.org
Cc: fweimer@redhat.com
Subject: [PATCH 0/2] Cleanup some calls to write with unused result
Date: Tue, 01 Nov 2016 00:44:00 -0000	[thread overview]
Message-ID: <1477961028-12150-1-git-send-email-gftg@linux.vnet.ibm.com> (raw)

While working on https://sourceware.org/ml/libc-alpha/2016-10/msg00535.html, I
became aware of write_message.  This patch is a similar cleanup for other parts
of the code.

The first patch only replaces calls to write on stdout,  whereas the second
also adds a new function which writes to stderr, instead of stdout.

Is this a good cleanup?

Tested for powerpc64le.

Gabriel F. T. Gomes (2):
  Use write_message instead of write
  Add write_message_to_stderr and use it instead of write

 nptl/tst-basic1.c   | 15 ++++++++-------
 nptl/tst-cleanup1.c | 11 ++++++-----
 nptl/tst-cleanup3.c | 11 ++++++-----
 nptl/tst-key1.c     | 11 ++++++-----
 nptl/tst-key2.c     | 23 ++++++++++++-----------
 nptl/tst-key3.c     | 31 ++++++++++++++++---------------
 nptl/tst-kill3.c    | 13 +++++++------
 nptl/tst-kill6.c    | 15 ++++++++-------
 nptl/tst-stdio1.c   |  2 +-
 nptl/tst-stdio2.c   | 11 ++++++-----
 nptl/tst-tls2.c     | 15 ++++++++-------
 nptl/tst-tls3.c     | 13 +++++++------
 test-skeleton.c     |  9 +++++++++
 13 files changed, 100 insertions(+), 80 deletions(-)

-- 
2.4.11

             reply	other threads:[~2016-11-01  0:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01  0:44 Gabriel F. T. Gomes [this message]
2016-11-01  0:44 ` [PATCH 2/2] Add write_message_to_stderr and use it instead of write Gabriel F. T. Gomes
2016-11-07 17:32   ` Florian Weimer
2016-11-08  0:41     ` Gabriel F. T. Gomes
2016-11-01  0:44 ` [PATCH 1/2] Use write_message " Gabriel F. T. Gomes
2016-11-07 17:33   ` Florian Weimer
2016-11-08  0:40     ` Gabriel F. T. Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477961028-12150-1-git-send-email-gftg@linux.vnet.ibm.com \
    --to=gftg@linux.vnet.ibm.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).