From: Florian Weimer <fweimer@redhat.com>
To: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] Add write_message_to_stderr and use it instead of write
Date: Mon, 07 Nov 2016 17:32:00 -0000 [thread overview]
Message-ID: <1360b678-e145-a434-fd14-3d1d69b7239b@redhat.com> (raw)
In-Reply-To: <1477961028-12150-3-git-send-email-gftg@linux.vnet.ibm.com>
On 11/01/2016 01:43 AM, Gabriel F. T. Gomes wrote:
>
> +/* Write a message to standard error. Can be used in signal handlers. */
> +static void
> +__attribute__ ((unused))
> +write_message_to_stderr (const char *message)
> +{
> + ssize_t unused __attribute__ ((unused));
> + unused = write (STDERR_FILENO, message, strlen (message));
> +}
These messages should really go to standard output, so you can adjust
the tests to use plain write_message instead and drop this hunk.
Thanks,
Florian
next prev parent reply other threads:[~2016-11-07 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 0:44 [PATCH 0/2] Cleanup some calls to write with unused result Gabriel F. T. Gomes
2016-11-01 0:44 ` [PATCH 2/2] Add write_message_to_stderr and use it instead of write Gabriel F. T. Gomes
2016-11-07 17:32 ` Florian Weimer [this message]
2016-11-08 0:41 ` Gabriel F. T. Gomes
2016-11-01 0:44 ` [PATCH 1/2] Use write_message " Gabriel F. T. Gomes
2016-11-07 17:33 ` Florian Weimer
2016-11-08 0:40 ` Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360b678-e145-a434-fd14-3d1d69b7239b@redhat.com \
--to=fweimer@redhat.com \
--cc=gftg@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).