* Fix linknamespace parallel test failures [committed]
@ 2016-11-03 22:48 Joseph Myers
2016-11-04 10:02 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2016-11-03 22:48 UTC (permalink / raw)
To: libc-alpha
Having found that with my script to build many glibc variants I could
reproduce the linknamespace test failures in parallel builds (that
various people had previously reported but I hadn't seen myself), I
investigated those failures further. This patch adds a missing
dependency to those tests.
Tested for x86_64, including the configuration where I saw those
failures and where I don't see them with this patch. Committed.
2016-11-03 Joseph Myers <joseph@codesourcery.com>
* conform/Makefile ($(linknamespace-header-tests)): Also depend on
$(linknamespace-symlists-tests).
diff --git a/conform/Makefile b/conform/Makefile
index b92a7d4..7883624 100644
--- a/conform/Makefile
+++ b/conform/Makefile
@@ -229,6 +229,7 @@ $(linknamespace-symlist-stdlibs-tests): $(objpfx)symlist-stdlibs-%: \
$(linknamespace-header-tests): $(objpfx)%/linknamespace.out: \
linknamespace.pl \
+ $(linknamespace-symlists-tests) \
$(linknamespace-symlist-stdlibs-tests)
(set -e; std_hdr=$*; std=$${std_hdr%%/*}; hdr=$${std_hdr#*/}; \
mkdir -p $(@D)/scratch; \
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Fix linknamespace parallel test failures [committed]
2016-11-03 22:48 Fix linknamespace parallel test failures [committed] Joseph Myers
@ 2016-11-04 10:02 ` Florian Weimer
2016-11-04 17:28 ` Steve Ellcey
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2016-11-04 10:02 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha
On 11/03/2016 11:47 PM, Joseph Myers wrote:
> 2016-11-03 Joseph Myers <joseph@codesourcery.com>
>
> * conform/Makefile ($(linknamespace-header-tests)): Also depend on
> $(linknamespace-symlists-tests).
I tried this on a medium-to-large x86_64 machine (120 cores/240
threads), and I had linknamespace failures before this commit, which are
gone after it. Thanks!
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix linknamespace parallel test failures [committed]
2016-11-04 10:02 ` Florian Weimer
@ 2016-11-04 17:28 ` Steve Ellcey
0 siblings, 0 replies; 3+ messages in thread
From: Steve Ellcey @ 2016-11-04 17:28 UTC (permalink / raw)
To: Florian Weimer, Joseph Myers; +Cc: libc-alpha
On Fri, 2016-11-04 at 11:01 +0100, Florian Weimer wrote:
> On 11/03/2016 11:47 PM, Joseph Myers wrote:
> >
> > 2016-11-03  Joseph Myers  <joseph@codesourcery.com>
> >
> > * conform/Makefile ($(linknamespace-header-tests)): Also depend
> > on
> > $(linknamespace-symlists-tests).
> I tried this on a medium-to-large x86_64 machine (120 cores/240Â
> threads), and I had linknamespace failures before this commit, which
> are gone after it.  Thanks!
>
> Florian
It fixed the problem for me on my aarch64 box too. Â Thanks Joseph.
Steve Ellcey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-04 17:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-03 22:48 Fix linknamespace parallel test failures [committed] Joseph Myers
2016-11-04 10:02 ` Florian Weimer
2016-11-04 17:28 ` Steve Ellcey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).