From: Stefan Liebler <stli@linux.ibm.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] test-container: Install with $(all-subdirs) [BZ #24794]
Date: Wed, 24 Jul 2019 14:48:00 -0000 [thread overview]
Message-ID: <17162ecb-9c00-34db-ffe6-2b0cfdcdcd44@linux.ibm.com> (raw)
In-Reply-To: <87muh4zpc2.fsf@linux.ibm.com>
Hi,
starting with this commit, I see the following fail:
cat nss/tst-nss-files-hosts-long.out
error: tst-nss-files-hosts-long.c:35: ahostsv4 failed
error: 1 test failures
Does anybody else also see this fail?
While running "make check" I've recognized the output of
support/shell-container.c:
sh: execing getent failed: No such file or directory File
sh: execing /usr/bin/makedb failed: No such file or directory File
And indeed getent does not exist in <build-dir>/testroot.root or
<build-dir>/testroot.pristine. Without this commit, it was available.
In older logs, I've found these commands:
/usr/bin/install -c build/nss/getent
build/testroot.pristine/usr/bin/getent.new
/usr/bin/install -c build/nss/makedb
build/testroot.pristine/usr/bin/makedb.new
mv -f build/testroot.pristine/usr/bin/getent.new
build/testroot.pristine/usr/bin/getent
mv -f build/testroot.pristine/usr/bin/makedb.new
build/testroot.pristine/usr/bin/makedb
Can anybody help?
Bye
Stefan
On 7/23/19 6:29 PM, Tulio Magno Quites Machado Filho wrote:
> DJ Delorie <dj@redhat.com> writes:
>
>> Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> writes:
>>> Whenever a sub-make is created, it inherits the variable subdirs from its
>>> parent. This is also true when make check is called with a restricted
>>> list of subdirs. In this scenario, make install is executed "partially"
>>> and testroot.pristine ends up with an incomplete installation.
>>
>> "obvious in retrospect" Sigh.
>>
>>> 2019-07-22 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>>>
>>> [BZ #24794]
>>> * Makefile (testroot.pristine/install.stamp): Pass
>>> subdirs='$(all-subdirs)' to make install.
>>
>> LGTM. Thanks!
>>
>> Reviewed-by: DJ Delorie <dj@redhat.com>
>
> Pushed as 35e038c1d2ccb.
>
> Thanks!
>
next prev parent reply other threads:[~2019-07-24 14:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:32 [PATCH] test-in-container: Install locales into the test container Florian Weimer
2019-07-09 18:07 ` DJ Delorie
2019-07-09 20:52 ` Florian Weimer
2019-07-09 20:59 ` DJ Delorie
2019-07-09 21:02 ` Florian Weimer
2019-07-09 21:11 ` Partial test suite run builds corrupt test-in-container testroot Carlos O'Donell
2019-07-10 0:36 ` DJ Delorie
2019-07-10 5:50 ` Florian Weimer
2019-07-10 16:34 ` DJ Delorie
2019-07-10 16:35 ` Florian Weimer
2019-07-10 16:38 ` DJ Delorie
2019-07-19 11:52 ` Florian Weimer
2019-07-22 20:45 ` [PATCH] test-container: Install with $(all-subdirs) [BZ #24794] Tulio Magno Quites Machado Filho
2019-07-22 20:56 ` DJ Delorie
2019-07-23 16:29 ` Tulio Magno Quites Machado Filho
2019-07-24 14:48 ` Stefan Liebler [this message]
2019-07-24 15:32 ` Tulio Magno Quites Machado Filho
2019-07-24 20:40 ` Carlos O'Donell
2019-07-24 23:50 ` DJ Delorie
2019-07-25 0:03 ` [PATCH] test-container: Install with $(sorted-subdirs) " Tulio Magno Quites Machado Filho
2019-07-25 1:32 ` DJ Delorie
2019-07-25 12:46 ` Szabolcs Nagy
2019-07-25 12:56 ` Carlos O'Donell
2019-07-29 13:36 ` Tulio Magno Quites Machado Filho
2022-01-27 15:25 ` H.J. Lu
2019-07-25 13:24 ` Stefan Liebler
2019-07-09 21:08 ` [PATCH] test-in-container: Install locales into the test container Carlos O'Donell
2019-07-09 23:55 ` DJ Delorie
2019-07-12 4:02 ` Carlos O'Donell
2019-07-12 5:49 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17162ecb-9c00-34db-ffe6-2b0cfdcdcd44@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).