From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] linux: fix ntp_gettime abi break
Date: Wed, 8 Mar 2023 09:31:12 -0300 [thread overview]
Message-ID: <18bac4b1-2729-efc7-c529-3f79bf79a34b@linaro.org> (raw)
In-Reply-To: <87bkl3seeg.fsf@oldenburg.str.redhat.com>
On 08/03/23 07:53, Florian Weimer via Libc-alpha wrote:
> * Kacper Piwiński via Libc-alpha:
>
>> From 57cfc759e3982ad591cf4d8c5f3392daf3799b3f Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Kacper=20Piwi=C5=84ski?= <vfjpl1@gmail.com>
>> Date: Wed, 8 Mar 2023 10:14:16 +0100
>> Subject: [PATCH v2] linux: fix ntp_gettime abi break
>>
>> Resolves #30156
>
> Could you please reference the commit(s) which introduced the ABI change
> in the commit message?
You can use your initial commit message:
--
Between versions v2.11 and v2.12 struct ntptimeval got new fields.
That wasn't a problem because new function ntp_gettimex was created
(and made default) to support new struct. Old ntp_gettime was not
using new fields so it was safe to call with old struct
definition. Then commits 5613afe9e3dff and b6ad64b907a (added for
64 bit time_t support), ntp_gettime start setting new fields.
Sets fields manually to maintain compatibility with v2.11 struct
definition.
--
next prev parent reply other threads:[~2023-03-08 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:23 Kacper Piwiński
2023-03-08 10:53 ` Florian Weimer
2023-03-08 12:31 ` Adhemerval Zanella Netto [this message]
2023-03-09 10:40 ` Kacper Piwiński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18bac4b1-2729-efc7-c529-3f79bf79a34b@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).