From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Mark Wielaard <mark@klomp.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Guard tst-valgrind-smoke.out with run-built-tests
Date: Wed, 26 Jan 2022 17:08:48 -0300 [thread overview]
Message-ID: <1d1c6201-c647-ece0-3c2e-1f6dc31e2ec3@linaro.org> (raw)
In-Reply-To: <20220126195737.45163-1-mark@klomp.org>
On 26/01/2022 16:57, Mark Wielaard wrote:
> Prevent tst-valgrind-smoke from running when run-built-tests is not yes.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> elf/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> Resent as separate PATCH to get it into patchwork.
>
> diff --git a/elf/Makefile b/elf/Makefile
> index daafb5cf12..775c755291 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -530,7 +530,9 @@ endif
> endif
> endif
>
> +ifeq ($(run-built-tests),yes)
> tests-special += $(objpfx)tst-valgrind-smoke.out
> +endif
> $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)valgrind-test
> $(SHELL) $< $(objpfx)ld.so $(rtlddir)/$(rtld-installed-name) '$(test-wrapper-env)' \
> '$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test > $@; $(evaluate-test)
next prev parent reply other threads:[~2022-01-26 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 19:57 Mark Wielaard
2022-01-26 20:08 ` Adhemerval Zanella [this message]
2022-01-26 22:49 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1c6201-c647-ece0-3c2e-1f6dc31e2ec3@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).